Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of add_row_number by using the Java index instead of Enso one #8055

Closed
4 tasks done
radeusgd opened this issue Oct 13, 2023 · 1 comment · Fixed by #8076
Closed
4 tasks done

Improve performance of add_row_number by using the Java index instead of Enso one #8055

radeusgd opened this issue Oct 13, 2023 · 1 comment · Fixed by #8076
Assignees
@radeusgd
Labels
--low-performance -libs Libraries: New libraries to be implemented

Comments

@radeusgd
Copy link
Member

radeusgd commented Oct 13, 2023 •
edited
Loading

It has been reported that add_row_number is too slow. We suspect the Enso Unordered_Multi_Value_Key is too slow in comparison to the Java counterpart.

  • Add a simple benchmark for add_row_number - with and without order_by.
  • Switch the implementation to use Java UnorderedMultiValueKey instead.
  • Compare the performance and see if it is satisfactory.
  • (follow up PR to not stall the fix) Add a benchmark comparing performance of the Java and Enso key implementations, so that we can try to improve it.
@radeusgd radeusgd self-assigned this Oct 13, 2023
@radeusgd radeusgd added -libs Libraries: New libraries to be implemented --low-performance labels Oct 13, 2023
@radeusgd radeusgd moved this from ❓New to 🔧 Implementation in Issues Board Oct 13, 2023
@enso-bot enso-bot bot mentioned this issue Oct 16, 2023
Merged
5 tasks
@radeusgd radeusgd mentioned this issue Oct 16, 2023
Merged
5 tasks
@mergify mergify bot closed this as completed in #8076 Oct 17, 2023
mergify bot pushed a commit that referenced this issue Oct 17, 2023
@radeusgd
Improve performance of add_row_number (#8076)
e9fa127 
Fixes #8055
@github-project-automation github-project-automation bot moved this from 🔧 Implementation to 🟢 Accepted in Issues Board Oct 17, 2023
@enso-bot
Copy link

enso-bot bot commented Oct 17, 2023

Radosław Waśko reports a new STANDUP for yesterday (2023-10-16):

Progress: Applying review suggestions, ensuring add_row_number fix is updated with the Problem Handling changes, getting both PRs merged. It should be finished by 2023-10-16.

Next Day: Next day I will be working on the same task. Finish follow up benchmarks, start next tasks.

@radeusgd radeusgd mentioned this issue Oct 17, 2023
Merged
5 tasks
mergify bot pushed a commit that referenced this issue Oct 18, 2023
@radeusgd
Add benchmarks related to add_row_number performance investigation (#…
93a31fc 
…8091)

- Follow-up of #8055
- Adds a benchmark comparing performance of Enso Map and Java HashMap in two scenarios - _only incremental_ updates (like `Vector.distinct`) and _replacing_ updates (like keeping a counter for each key). These benchmarks can be used as a metric for #8090
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@radeusgd radeusgd

Labels
--low-performance -libs Libraries: New libraries to be implemented
Projects
Issues Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve performance of add_row_number enso-org/enso
1 participant
@radeusgd