Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache filtered children in XML #7998

Merged
merged 70 commits into from
Oct 6, 2023
Merged

Conversation

GregoryTravis
Copy link
Contributor

@GregoryTravis GregoryTravis commented Oct 6, 2023

Pull Request Description

We currently scan the entire child list for each call to children, num_children, and get_child_element.

Instead, we should cache the filtered child list on first access.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@GregoryTravis GregoryTravis marked this pull request as ready for review October 6, 2023 14:20
@GregoryTravis GregoryTravis added the CI: No changelog needed Do not require a changelog entry for this PR. label Oct 6, 2023
@GregoryTravis GregoryTravis linked an issue Oct 6, 2023 that may be closed by this pull request
Copy link
Member

@radeusgd radeusgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good, just one minor style comment

Base automatically changed from wip/gmt/7739-xml to develop October 6, 2023 17:52
@GregoryTravis GregoryTravis added the CI: Ready to merge This PR is eligible for automatic merge label Oct 6, 2023
@mergify mergify bot merged commit a90af9f into develop Oct 6, 2023
@mergify mergify bot deleted the wip/gmt/7950-xml-child-cache branch October 6, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cache filtered children in XML
3 participants