Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache filtered children in XML #7950

Closed
GregoryTravis opened this issue Oct 2, 2023 · 0 comments · Fixed by #7998
Closed

Cache filtered children in XML #7950

GregoryTravis opened this issue Oct 2, 2023 · 0 comments · Fixed by #7998
Assignees
@GregoryTravis
Labels
-libs Libraries: New libraries to be implemented p-low Low priority

Comments

@GregoryTravis
Copy link
Contributor

We currently scan the entire child list for each call to children, num_children, and get_child_element.

Instead, we should cache the filtered child list on first access.
@GregoryTravis GregoryTravis self-assigned this Oct 2, 2023
@github-project-automation github-project-automation bot moved this to ❓New in Issues Board Oct 2, 2023
@GregoryTravis GregoryTravis added p-low Low priority -libs Libraries: New libraries to be implemented labels Oct 2, 2023
@GregoryTravis GregoryTravis mentioned this issue Oct 2, 2023
Merged
5 tasks
@jdunkerley jdunkerley moved this from ❓New to 📤 Backlog in Issues Board Oct 3, 2023
@GregoryTravis GregoryTravis linked a pull request Oct 6, 2023 that will close this issue
Cache filtered children in XML #7998
Merged
5 tasks
@mergify mergify bot closed this as completed in #7998 Oct 6, 2023
@github-project-automation github-project-automation bot moved this from 📤 Backlog to 🟢 Accepted in Issues Board Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GregoryTravis GregoryTravis

Labels
-libs Libraries: New libraries to be implemented p-low Low priority
Projects
Issues Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cache filtered children in XML enso-org/enso
1 participant
@GregoryTravis