Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logic for enabling dashboard #6696

Merged
merged 2 commits into from
May 15, 2023
Merged

Fix logic for enabling dashboard #6696

merged 2 commits into from
May 15, 2023

Conversation

somebody1234
Copy link
Contributor

Pull Request Description

Fixes regression introduced by #6671, preventing the dashboard from being opened because startup.entry is never the empty string

Important Notes

None

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@PabloBuchu PabloBuchu added the CI: No changelog needed Do not require a changelog entry for this PR. label May 15, 2023
@somebody1234
Copy link
Contributor Author

somebody1234 commented May 15, 2023 •
edited
Loading

(note: it is not tested whether the IDE backend works with gui watch; I don't think I have a standalone project manager executable handy)
dashboard is enabled for:

  • ✔️ ide watch + new-dashboard + authentication
  • ✔️ gui watch + new-dashboard + authentication

dashboard is disabled for:

  • ✔️ ide watch + new-dashboard + authentication + startup.project
  • ✔️ gui watch + new-dashboard + authentication + startup.project
  • ✔️ gui watch + alternate startup.entry
  • ✔️ ide watch + startup.project (expected, since new-dashboard and authentication are currently disabled by default)
  • ✔️ gui watch + startup.project
  • ✔️ gui watch + alternate startup.entry

@PabloBuchu PabloBuchu merged commit 23e75f5 into develop May 15, 2023
@PabloBuchu PabloBuchu deleted the wip/sb/fix-logic-for-enabling-dashboard branch May 15, 2023 14:06
Procrat added a commit that referenced this pull request May 16, 2023
@Procrat
Merge branch 'develop' into wip/procrat/shift-space-for-fullscreen-vi…
07e7d46 
…z-6260

* develop:
  Add verbose logs mention to CONTRIBUTING.md (#6703)
  Hide "shared with" column on local backend (#6684)
  Fix top bar styles (#6695)
  Fix opening cloud projects (#6683)
  Show spinner when opening/creating a project (#6321)
  Fix logic for enabling dashboard (#6696)
  Create unique atom getter suggestions (#6694)
  Ensure slow shutdown of LS always kicks off hooks (#6665)
  Fix `--startup.project` to bypass opening dashboard (#6671)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PabloBuchu PabloBuchu PabloBuchu approved these changes

@indiv0 indiv0 Awaiting requested review from indiv0 indiv0 is a code owner

Assignees
No one assigned
Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@somebody1234 @PabloBuchu