Ensure slow shutdown of LS always kicks off hooks #6665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes the rather elusive bug where shutdown hooks could not be fired when shutdown was taking too long and termination was forced. Under the circumstances described in detail in ticket #6515 there was a small chance that we could have a shutdown race condition. Essentially the messages received when client was disconnected and language server forced the termination could lead to language server not sending the public `ProjectClosed` message which triggers shutdown hook. Now we always do. Also made sure that multiple `ProjectClosed` messages don't lead to firing multiple shutdown hooks, which was another possibility.
hubertp
commented
May 12, 2023
| ) | ||
| liveControllers.foreach { case (actorRef, projectId) => | ||
| actorRef ! PoisonPill | ||
| context.system.eventStream.publish(ProjectClosed(projectId)) |
There was a problem hiding this comment.
If one was to reduce this fix to a single line, then this is it.
hubertp
added
the
CI: No changelog needed
JaroslavTulach
approved these changes
May 15, 2023
4e6
approved these changes
May 15, 2023
Procrat
added a commit
that referenced
this pull request
May 16, 2023
…z-6260 * develop: Add verbose logs mention to CONTRIBUTING.md (#6703) Hide "shared with" column on local backend (#6684) Fix top bar styles (#6695) Fix opening cloud projects (#6683) Show spinner when opening/creating a project (#6321) Fix logic for enabling dashboard (#6696) Create unique atom getter suggestions (#6694) Ensure slow shutdown of LS always kicks off hooks (#6665) Fix `--startup.project` to bypass opening dashboard (#6671)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This change fixes the rather elusive bug where shutdown hooks could not be fired when shutdown was taking too long and termination was forced.
Under the circumstances described in detail in ticket #6515 there was a small chance that we could have a shutdown race condition. Essentially the messages received when client was disconnected and language server forced the termination could lead to language server not sending the public
ProjectClosedmessage which triggers shutdown hook. Now we always do.Also made sure that multiple
ProjectClosedmessages don't lead to firing multiple shutdown hooks, which was another possibility.No tests as one would have to be able to introduce different delays in various message handlers to simulate the problem.
Having ability to do such chaos testing would be nice but it is beyond the scope of this ticket.
I was able to reproduce the problem 100% with my specially crafted setup so I'm fairly confident about the change.
Closes #6515.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.