Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add COOP+COEP+CORP headers (#6597)" #6647

Merged
merged 1 commit into from
May 11, 2023
Merged

Revert "Add COOP+COEP+CORP headers (#6597)" #6647

merged 1 commit into from
May 11, 2023

Conversation

PabloBuchu
Copy link
Contributor

This reverts commit 9597dd3.

Pull Request Description

This PR reverts latest changes regarding introducing COOP COEP CORP headers. It broke the map visualization (#6645)

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@PabloBuchu PabloBuchu added CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge labels May 11, 2023
@mergify mergify bot merged commit d853851 into develop May 11, 2023
@mergify mergify bot deleted the wip/pb/revert-new-headers branch May 11, 2023 12:23
somebody1234 added a commit that referenced this pull request May 11, 2023
@somebody1234
Revert "Revert "Add COOP+COEP+CORP headers (#6597)" (#6647)"
8657fe3 
This reverts commit d853851.
Procrat added a commit that referenced this pull request May 12, 2023
@Procrat
Merge branch 'develop' into wip/procrat/home-button-6399
5a86e4a 
* develop:
  Implement loading spinner for visualisations. (#6512)
  Fix blank input port (#6614)
  Add `Date_Range` (#6621)
  All Vector operations shall be applicable on java.util.ArrayList (#6642)
  Fix redirect paths and enable authentication and new dashboard by default (#6605)
  Fix #6287: wrong nested breadcrumb ordering (#6617)
  Whitelist AWS Cognito domains (#6643)
  Revert "Add COOP+COEP+CORP headers (#6597)" (#6647)
  Fix shortcuts table formatting (#6644)
  Automatic type based dropdown does not include singleton in a union type (#6629)
  Make Meta.get_annotation work for constructor (#6633)
PabloBuchu pushed a commit that referenced this pull request May 12, 2023
@somebody1234
Add COOP+COEP+CORP headers (#6646)
4b64d66 
* Revert "Revert "Add COOP+COEP+CORP headers (#6597)" (#6647)"

This reverts commit d853851.

* Fix loading third-party resources
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@somebody1234 somebody1234 somebody1234 approved these changes

@indiv0 indiv0 Awaiting requested review from indiv0 indiv0 is a code owner

Assignees
No one assigned
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PabloBuchu @somebody1234