Revert "Add COOP+COEP+CORP headers (#6597)" (#6647)

This PR reverts latest changes regarding introducing COOP COEP CORP headers. It broke the map visualization (#6645)

app/ide-desktop/lib/client/src/bin/server.ts

@@ -8,7 +8,6 @@ import * as mime from 'mime-types'
 import * as portfinder from 'portfinder'
 import createServer from 'create-servers'
 
-import * as common from 'enso-common'
 import * as contentConfig from 'enso-content-config'
 
 import * as paths from '../paths'
@@ -106,9 +105,6 @@ export class Server {
                 resource === '/preload.cjs.map'
                     ? `${paths.APP_PATH}${resource}`
                     : `${this.config.dir}${resource}`
-            for (const [header, value] of common.COOP_COEP_CORP_HEADERS) {
-                response.setHeader(header, value)
-            }
             fs.readFile(resourceFile, (err, data) => {
                 if (err) {
                     logger.error(`Resource '${resource}' not found.`)

app/ide-desktop/lib/common/src/index.ts

@@ -1,5 +1,4 @@
-/** @file This module contains metadata about the product and distribution,
- * and various other constants that are needed in multiple sibling packages.
+/** @file This module contains metadata about the product and distribution.
  *
  * Code in this package is used by two or more sibling packages of this package. The code is defined
  * here when it is not possible for a sibling package to own that code without introducing a
@@ -13,13 +12,3 @@ export const DEEP_LINK_SCHEME = 'enso'
 
 /** Name of the product. */
 export const PRODUCT_NAME = 'Enso'
-
-/** COOP, COEP, and CORP headers: https://web.dev/coop-coep/
- *
- * These are required to increase the resolution of `performance.now()` timers,
- * making profiling a lot more accurate and consistent. */
-export const COOP_COEP_CORP_HEADERS: [header: string, value: string][] = [
-    ['Cross-Origin-Embedder-Policy', 'require-corp'],
-    ['Cross-Origin-Opener-Policy', 'same-origin'],
-    ['Cross-Origin-Resource-Policy', 'same-origin'],
-]

app/ide-desktop/lib/content/esbuild-config.ts

@@ -26,11 +26,7 @@ import esbuildPluginYaml from 'esbuild-plugin-yaml'
 import * as utils from '../../utils'
 import BUILD_INFO from '../../build.json' assert { type: 'json' }
 
-// =================
-// === Constants ===
-// =================
-
-const THIS_PATH = pathModule.resolve(pathModule.dirname(url.fileURLToPath(import.meta.url)))
+export const THIS_PATH = pathModule.resolve(pathModule.dirname(url.fileURLToPath(import.meta.url)))
 
 // =============================
 // === Environment variables ===

app/ide-desktop/lib/content/src/index.ts

@@ -20,9 +20,6 @@ const logger = app.log.logger
 const ESBUILD_PATH = '/esbuild'
 /** SSE event indicating a build has finished. */
 const ESBUILD_EVENT_NAME = 'change'
-/** Path to the service worker that resolves all extensionless paths to `/index.html`.
- * This service worker is required for client-side routing to work when doing local development. */
-const SERVICE_WORKER_PATH = '/serviceWorker.js'
 /** One second in milliseconds. */
 const SECOND = 1000
 /** Time in seconds after which a `fetchTimeout` ends. */
@@ -36,7 +33,6 @@ if (IS_DEV_MODE) {
     new EventSource(ESBUILD_PATH).addEventListener(ESBUILD_EVENT_NAME, () => {
         location.reload()
     })
-    void navigator.serviceWorker.register(SERVICE_WORKER_PATH)
 }
 
 // =============

app/ide-desktop/lib/content/watch.ts

@@ -1,7 +1,4 @@
 /** @file File watch and compile service. */
-import * as path from 'node:path'
-import * as url from 'node:url'
-
 import * as esbuild from 'esbuild'
 import * as portfinder from 'portfinder'
 import chalk from 'chalk'
@@ -15,7 +12,6 @@ import * as dashboardBundler from '../dashboard/esbuild-config'
 
 const PORT = 8080
 const HTTP_STATUS_OK = 200
-const THIS_PATH = path.resolve(path.dirname(url.fileURLToPath(import.meta.url)))
 
 // ===============
 // === Watcher ===
@@ -33,10 +29,6 @@ async function watch() {
         ...bundler.argumentsFromEnv(),
         devMode: true,
     })
-    opts.entryPoints.push({
-        in: path.resolve(THIS_PATH, 'src', 'serviceWorker.ts'),
-        out: 'serviceWorker',
-    })
     const builder = await esbuild.context(opts)
     await builder.watch()
     await builder.serve({

app/ide-desktop/lib/dashboard/src/authentication/src/components/svg.tsx

@@ -254,16 +254,6 @@ export const COMPUTER_ICON = (
     </svg>
 )
 
-/** An icon representing a user without a profile picture. */
-export const DEFAULT_USER_ICON = (
-    <svg height={32} width={32} viewBox="2 2 20 20" xmlns="http://www.w3.org/2000/svg">
-        <path
-            d="M6 20a10 10 0 0 1 6 -18 10 10 0 0 1 6 18 6 6 0 0 0 -4 -5 4.3 4.3 0 0 0 -2 -8 4.3 4.3 0 0 0 -2 8 6 6 0 0 0 -4 5"
-            fill="#888888"
-        />
-    </svg>
-)
-
 export interface StopIconProps {
     className?: string
 }

app/ide-desktop/lib/dashboard/src/authentication/src/dashboard/components/dashboard.tsx

@@ -471,7 +471,10 @@ function Dashboard(props: DashboardProps) {
                         key={user.user.organization_id}
                         permissions={PERMISSION[user.permission]}
                     >
-                        {svg.DEFAULT_USER_ICON}
+                        <img
+                            className="rounded-full h-6"
+                            src="https://faces-img.xcdn.link/image-lorem-face-4742.jpg"
+                        />
                     </PermissionDisplay>
                 ))}
             </>

app/ide-desktop/lib/dashboard/src/authentication/src/dashboard/components/topBar.tsx

@@ -120,15 +120,14 @@ function TopBar(props: TopBarProps) {
             </a>
             {/* User profile and menu. */}
             <div className="transform">
-                <div
+                <img
+                    src="https://faces-img.xcdn.link/image-lorem-face-4742.jpg"
+                    className="rounded-full w-8 h-8 bg-cover cursor-pointer"
                     onClick={event => {
                         event.stopPropagation()
                         setUserMenuVisible(!userMenuVisible)
                     }}
-                    className="rounded-full w-8 h-8 bg-cover cursor-pointer"
-                >
-                    {svg.DEFAULT_USER_ICON}
-                </div>
+                />
             </div>
         </div>
     )

app/ide-desktop/lib/dashboard/src/serviceWorker.ts

@@ -1,9 +1,6 @@
 /** @file A service worker that redirects paths without extensions to `/index.html`.
- * This is required for paths like `/login`, which are handled by client-side routing,
- * to work when developing locally on `localhost:8081`. */
-// Bring globals and interfaces specific to Web Workers into scope.
+ * This is only used in the cloud frontend. */
 /// <reference lib="WebWorker" />
-import * as common from 'enso-common'
 
 // =====================
 // === Fetch handler ===
@@ -15,21 +12,17 @@ declare const self: ServiceWorkerGlobalScope
 
 self.addEventListener('fetch', event => {
     const url = new URL(event.request.url)
-    if (url.hostname === 'localhost' && url.pathname !== '/esbuild') {
-        const responsePromise = /\/[^.]+$/.test(event.request.url)
-            ? fetch('/index.html')
-            : fetch(event.request.url)
-        event.respondWith(
-            responsePromise.then(response => {
-                const clonedResponse = new Response(response.body, response)
-                for (const [header, value] of common.COOP_COEP_CORP_HEADERS) {
-                    clonedResponse.headers.set(header, value)
-                }
-                return clonedResponse
-            })
-        )
+    if (
+        url.hostname === 'localhost' &&
+        /\/[^.]+$/.test(event.request.url) &&
+        url.pathname !== '/esbuild'
+    ) {
+        event.respondWith(fetch('/index.html'))
         return
     } else {
         return false
     }
 })
+
+// Required for TypeScript to consider it a module, instead of in window scope.
+export {}