-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support widgets and placeholders in more complex expressions #5656
Conversation
9ea001d
to
1db772d
Compare
No other issues found. |
Also, the trailing
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Yes, this looks to be an engine problem. What you see is that the node on the left started using
tag_values
(static dropdown data), which means the widget query didn't return a widget. I suspect that happens when that node's expression postion in the source file is below an expression that caused an evaluation exception. In this case, I believe that the filter condition expression causes it. Which engine version are you using?
I use nightly from 2023-02-15
- This looks wrong, and looks to be my fault. I'm going to investigate it further. Looks like expression groups don't create the right span tree.
I can confirm this fixed. As other bugs are related to the Engine, the QA is green.
3f35ec2
to
b01278e
Compare
Pull Request Description
Implements #5032
Added support for widgets in infix expressions (right now only used for file paths)
Widgets and placeholders are handled for all chained methods within a node
The qualified method call convention and static methods no longer confuse the argument placeholders
Type constructor expressions now receive placeholder arguments. The placeholders work on nested expressions within a node.
Checklist
Please include the following checklist in your PR:
Scala,
Java,
and
Rust
style guides.
./run ide build
and./run ide watch
.