Investigate what is missing for support of widgets in nested expressions

[wdanilo]

QA: @farmaazon

This task is automatically imported from the old Task Issue Board and it was originally created by Greg Ociepka.
Original issue is here.

---

Currently widgets are only provided directly to the arguments of each separate function call inside a node expression. This approach doesn't allow for the suggestions to be sensitive to the context in which the function call is made. Additionally, selecting a widget completion that results in a nested constructor call produces invalid expression and doesn't provide further widgets.

We need to investigate cases in which more elaborate widget structure would be useful for better completions. Additionally, we have to ensure that completed nested expressions also receive appropriate widgets in as many cases as possible.

Current behavior:

In expression:

table.filter "column" (Filter_Condition.Equal)

The "column" argument position is provided with actual column name suggestions.
The nested "to" argument of Filter_Condition constructor does not have a placeholder or widget.

Acceptance criteria:

Given starting expression

table.filter

• placeholders or widgets with valid suggestions must be provided for both "column" and "filter" arguments
• "filter" argument suggestions must allow picking various variants of Filter_Condition
• after "filter" argument suggestion with Filter_Condition.Equal variant is applied, the "to" argument should receive an argument placeholder

Blockers:

#184382080 blocked

Comments:

Paweł Grabarz reports a new STANDUP for today (2023-02-02):

Progress: Made a call with James to discuss the potential structure of nested widgets in parameters. We've figured that parameter nesting is not enough to implement desired widgets for filter, and it might not actually be a useful construct right now. Instead I've investigated what is preventing the widgets and placeholder arguments from showing on nested constructor expressions. This resulted in a bug report for engine. It should be finished by 2023-02-08. (Enso Bot - Feb 2, 2023)

---

[enso-bot]

Paweł Grabarz reports a new STANDUP for yesterday (2023-02-08):

Progress: Implemented support for widgets in single argument infix expressions, but it is still buggy in more complicated cases. More work is needed to support longer chains properly. Additionally spent some time on issue triage. It should be finished by 2023-02-14.

[enso-bot]

Paweł Grabarz reports a new STANDUP for today (2023-02-09):

Progress: Implementing widget support for longer infix chains is going well, but some tests need to be adjusted yet. I also found that basic prefix method application using longer access chains didn't work. It should be fixed in the process. Next I need to investigate how to add argument placeholders that are not at the end of the expression. It should be finished by 2023-02-14.

[enso-bot]

Paweł Grabarz reports a new STANDUP for yesterday (2023-02-13):

Progress: Added method resolution for constructors and fixed it for static calls, which got broken since suggestion database method resolution was changed to rely on full method pointers. Also improved self argument handling for qualified method calls. It should be finished by 2023-02-14.

[enso-bot]

Paweł Grabarz reports a new STANDUP for yesterday (2023-02-14):

Progress: Fixed all remaining issues detected by tests and cleaned up the code a bit before PR review. Discussed design of future implementation for in-node widgets. It should be finished by 2023-02-14.

[enso-bot]

Paweł Grabarz reports a new STANDUP for the provided date (2023-02-10):

Progress: Added method resolution for chained method calls within a single node. Tested recently added method resolution for constructors. The right data is sent by the language server, but more work is needed to use it properly on IDE side. It should be finished by 2023-02-14.

[enso-bot]

Paweł Grabarz reports a new STANDUP for the provided date (2023-02-03):

Progress: Working on recognition of infix expressions as function calls, in order to be able to connect widgets or argument placeholders to them. It should be finished by 2023-02-14.