Single (+patchable) LiteralNode #3536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4e6
approved these changes
Jun 20, 2022
engine/runtime/src/main/java/org/enso/interpreter/runtime/PatchedModuleValues.java
Outdated
Show resolved
Hide resolved
engine/runtime/src/main/java/org/enso/interpreter/runtime/PatchedModuleValues.java
Outdated
Show resolved
Hide resolved
JaroslavTulach
force-pushed
the
wip/jtulach/OneLiteralNode_182485854
branch
from
8a032aa to
029b027
Compare
|
Results of running benchmarks seem to be fine:
The |
JaroslavTulach
added
the
CI: Ready to merge
hubertp
reviewed
Jun 21, 2022
...runtime/src/main/java/org/enso/interpreter/node/expression/literal/PatchableLiteralNode.java
Show resolved
Hide resolved
kazcw
pushed a commit
that referenced
this pull request
Jun 29, 2022
This PR merges existing variants of `LiteralNode` (`Integer`, `BigInteger`, `Decimal`, `Text`) into a single `LiteralNode`. It adds `PatchableLiteralNode` variant (with non `final` `value` field) and uses `Node.replace` to modify the AST to be patchable. With such change one can remove the `UnwindHelper` workaround as `IdExecutionInstrument` now sees _patched_ return values without any tricks.
This was referenced Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ci no changelog needed]
Pull Request Description
This PR merges existing variants of
LiteralNode(Integer,BigInteger,Decimal,Text) into a singleLiteralNode. It addsPatchableLiteralNodevariant (with nonfinalvaluefield) and usesNode.replaceto modify the AST to be patchable. With such change one can remove theUnwindHelperworkaround asIdExecutionInstrumentnow sees patched return values without any tricks.Checklist
Please include the following checklist in your PR:
Scala,
Java,