Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GraalVM Logging & Caching Instrument Hack by having Generic LiteralNode #4392

Closed
4 tasks done
wdanilo opened this issue Feb 5, 2023 · 0 comments
Closed
4 tasks done

Comments

@wdanilo
Copy link
Member

wdanilo commented Feb 5, 2023

This task is automatically imported from the old Task Issue Board and it was originally created by jaroslavtulach.
Original issue is here.


While working #182412796 we found out problem in communication between the two instruments we have and reported that to GraalVM team. There is no simple solution to overcome this GraalVM limitation. #182412796 solved the problem by global "map", but we need better solution. Let's implement it as part of this task!

Resources

There are few *LiteralNode classes in engine. Let's replace them by single one. It shall not affect peak performance. Then, instead of using caching instrument/listener - directly Node.replace the LiteralNode by PatchedLiteralNode in the AST - modify the value directly in the PatchedLiteralNode.

Tasks:

  • Unify all LiteralNode classes into one
  • Benchmark the peak performance; avoid regression
  • Create PatchedLiteralNode
  • Remove caching instrument in PatchedModuleValues

Blockers:

#182412796 resolved

Comments:

Jaroslav Tulach reports a new STANDUP for yesterday (2022-06-21):

Progress: Single LiteralNode has been integrated: #3536; Analyzing and discussing sbt issue with javafmt: https://discord.com/channels/401396655599124480/988485281260916817/988802778296115200; debugging Enso launcher to place --dumpGraphs option. It should be finished by 2022-06-21.

Next Day: Finish --dumpGraphs option for Enso4IGV. (Enso Bot - Jun 22, 2022)


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants