Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enso Integration with Ideal Graph Visualizer #3533
Enso Integration with Ideal Graph Visualizer #3533
Changes from 12 commits
057aa6c
75b5ba4
b1eb32b
8eaee7a
16bfe00
52ebbf2
e828675
9d4aed6
0559799
4255973
342b43e
f2fcfd4
03d462b
870ef47
d651c83
e95041c
a6ecd23
b7a797d
3f92169
45e51f0
c49c766
1aab449
7d04edf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd upload the file and link here from this repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. It would be good to include sieve.enso and make it part of daily executed code. That way we know the syntax is correct and the engine can still run the file. Where should I put the
sieve.enso
file then? CCing @hubertp , @jdunkerley , @kustosz - thank you.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tools/enso4igv/examples
? Maybe there is something simpler we could add as well/instead?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It cannot be too simple program, it has to warmup. It could be any of the traditional benchmarks like N-body, Funkuch, etc. However I doubt they are simpler.
Anyway let's address this later. I am already behind the schedule and properly solving this (e.g. making sure the file is tested on each change in engine) requires additional thoughts.