-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enso Integration with Ideal Graph Visualizer #3533
Conversation
4e8d269
to
0ab2058
Compare
0ab2058
to
8eaee7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a great addition to Enso tools! Approving but I'd also like to see @mwu-tow approval on the CI part
719e497
to
98806e7
Compare
83e5ffa
to
990436d
Compare
990436d
to
9d4aed6
Compare
f786895
to
f2fcfd4
Compare
#### Sieve of Eratosthenes Example | ||
|
||
As an example you can download | ||
[sieve.enso](https://github.com/jtulach/sieve/blob/5b32450da35415322e683bb9769aa45f0d71f1df/enso/sieve.enso) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd upload the file and link here from this repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. It would be good to include sieve.enso and make it part of daily executed code. That way we know the syntax is correct and the engine can still run the file. Where should I put the sieve.enso
file then? CCing @hubertp , @jdunkerley , @kustosz - thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tools/enso4igv/examples
? Maybe there is something simpler we could add as well/instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It cannot be too simple program, it has to warmup. It could be any of the traditional benchmarks like N-body, Funkuch, etc. However I doubt they are simpler.
Anyway let's address this later. I am already behind the schedule and properly solving this (e.g. making sure the file is tested on each change in engine) requires additional thoughts.
Co-authored-by: Michał Wawrzyniec Urbańczyk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#### Sieve of Eratosthenes Example | ||
|
||
As an example you can download | ||
[sieve.enso](https://github.com/jtulach/sieve/blob/5b32450da35415322e683bb9769aa45f0d71f1df/enso/sieve.enso) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tools/enso4igv/examples
? Maybe there is something simpler we could add as well/instead?
Pull Request Description
This PR adds sources for Enso language support in IGV (and NetBeans). The support is based on TextMate grammar shown in the editor and registration of the Enso language so IGV can find it. Then this PR adds new GitHub Actions workflow file to build the project using Maven.
Important Notes
Checklist
Please include the following checklist in your PR:
.nbm
file somewhereJava,
style guides.