Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove listGroups while building categories #11988

Merged
merged 35 commits into from
Jan 15, 2025
Merged

Remove listGroups while building categories #11988

merged 35 commits into from
Jan 15, 2025
+429 −718

Conversation

MrFlashAccount
Copy link
Contributor

@MrFlashAccount MrFlashAccount commented Jan 6, 2025 •
edited
Loading

Pull Request Description

This PR adds new field called groups on the User object to avoid fetching the usergroups list to get the names of the groups.

Also this PR removes the <ManagePermisssionsModal />

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@MrFlashAccount MrFlashAccount self-assigned this Jan 6, 2025
@MrFlashAccount MrFlashAccount added g-dashboard CI: No changelog needed Do not require a changelog entry for this PR. labels Jan 6, 2025
@MrFlashAccount MrFlashAccount marked this pull request as ready for review January 6, 2025 13:06
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2025 •
edited
Loading

🧪 Storybook is successfully deployed!

📊 Dashboard:

somebody1234
somebody1234 approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@somebody1234 somebody1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR ✅

@MrFlashAccount MrFlashAccount mentioned this pull request Jan 7, 2025
Merged
5 tasks
@MrFlashAccount
Copy link
Contributor Author

Re-requesting CR as this PR changed after the latest code review

somebody1234
somebody1234 reviewed Jan 13, 2025
View reviewed changes
build.sbt Outdated Show resolved Hide resolved
somebody1234
somebody1234 approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@somebody1234 somebody1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR ✅
would like to get confirmation that we want to remove the manage permissions modal though

JaroslavTulach
JaroslavTulach previously requested changes Jan 14, 2025
View reviewed changes
Copy link
Member

@JaroslavTulach JaroslavTulach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes to project-manager, its legal, lib/scala, please.

distribution/project-manager/THIRD-PARTY/org.apache.tika.tika-core-2.4.1/NOTICE Outdated Show resolved Hide resolved
@PabloBuchu
Copy link
Contributor

  1. If I switch between accounts (Team -> Free -> Team) I am getting set orgzanization name modal desptie that my org has name.
    https://github.com/user-attachments/assets/4e3fa884-0cc4-42da-b117-19ad29f7261b

hubertp and others added 3 commits January 15, 2025 11:52
@hubertp @MrFlashAccount
Revert "Disable visualizations for subexpressions (#11949)" (#12050)
85dd211 
This reverts commit 1f763f7.
@MrFlashAccount
Invalidate queries when the user goes online + Fix offline mode (#11944)
4f31294 
Closes: enso-org/cloud-v2#1630

1. Invalidate remote backend queries when user goes online
2. Moves auth-related logic from `AuthProvider` to `SessionProvider`
3. Do not log user out if `users/me` returns 401
@MrFlashAccount
Fix Login/logout cache invalidation
93c7c62
@MrFlashAccount
Copy link
Contributor Author

@PabloBuchu should be addressed now

@MrFlashAccount
Merge branch 'develop' into wip/sergeigarin/remove-list-usergroups
08ef9fc 
# Conflicts:
#	app/gui/src/dashboard/layouts/UserMenu.tsx
#	app/gui/src/dashboard/providers/SessionProvider.tsx
@MrFlashAccount
Fix imports
1b4e94d
@MrFlashAccount
Fix ci
7a0e10b
@MrFlashAccount
Lint x2
6890e5b
@JaroslavTulach JaroslavTulach dismissed their stale review January 15, 2025 11:42

Changes outside of GUI were reverted.

@MrFlashAccount MrFlashAccount added the CI: Ready to merge This PR is eligible for automatic merge label Jan 15, 2025
@mergify mergify bot merged commit b1cc4f1 into develop Jan 15, 2025
37 of 40 checks passed
@mergify mergify bot deleted the wip/sergeigarin/remove-list-usergroups branch January 15, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@somebody1234 somebody1234 somebody1234 approved these changes

@PabloBuchu PabloBuchu PabloBuchu approved these changes

@Frizi Frizi Frizi approved these changes

@JaroslavTulach JaroslavTulach JaroslavTulach left review comments

@indiv0 indiv0 Awaiting requested review from indiv0 indiv0 is a code owner

@farmaazon farmaazon Awaiting requested review from farmaazon farmaazon is a code owner

@vitvakatu vitvakatu Awaiting requested review from vitvakatu vitvakatu is a code owner

@kazcw kazcw Awaiting requested review from kazcw kazcw is a code owner

@AdRiley AdRiley Awaiting requested review from AdRiley AdRiley is a code owner

@4e6 4e6 Awaiting requested review from 4e6

@hubertp hubertp Awaiting requested review from hubertp hubertp is a code owner

@Akirathan Akirathan Awaiting requested review from Akirathan

@jdunkerley jdunkerley Awaiting requested review from jdunkerley jdunkerley is a code owner

Assignees

@MrFlashAccount MrFlashAccount

Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge g-dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MrFlashAccount @PabloBuchu @Frizi @somebody1234 @JaroslavTulach @hubertp