Ignore port updates on removed nodes #10950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitvakatu
added
CI: No changelog needed
vitvakatu
requested review from
Frizi,
farmaazon,
kazcw and
AdRiley
as code owners
Frizi
approved these changes
Sep 2, 2024
| @@ -312,16 +312,24 @@ export const { injectFn: useGraphStore, provideFn: provideGraphStore } = createC | |||
|
|
|||
| function deleteNodes(ids: Iterable<NodeId>) { | |||
| edit((edit) => { | |||
| const deletedNodes = new Set() | |||
There was a problem hiding this comment.
I think we should collect all ids ahead of the main loop avoid modifying nodes that we are about to delete as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #10888, Fixes #10925
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.