Intermittent deletion failures #10888
Comments
kazcw
added a commit
that referenced
this issue
Aug 23, 2024
- Fix bug in deletion logic (the `syncModule` was passed to a function that tried to commit it as an edit) - Refactor APIs to avoid similar bugs (remove `direct` edit option; direct access to the sync module must be done by name)
kazcw
added a commit
that referenced
this issue
Aug 23, 2024
- Fix bug in deletion logic (the `syncModule` was passed to a function that tried to commit it as an edit) - Refactor APIs to avoid similar bugs (remove `direct` edit option; direct access to the sync module must be done by name)
4 tasks
mergify bot
pushed a commit
that referenced
this issue
Aug 28, 2024
Fix intermittent deletion failures (#10888) - Fix bug in deletion logic (the `syncModule` itself was passed to a function that tried to commit it as an edit) - Refactor APIs to avoid similar bugs (remove `direct` edit option) # Important Notes - `graphStore.getMutable` provides safer access to some of the functionality that was exposed by `direct` editing. - `graphStore.transact` has been eliminated; it was redundant with `graphStore.batchEdits`.
github-project-automation
bot
moved this from 👁️ Code review
to 🟢 Accepted
in Issues Board
|
#10889 did not fix the issue when removing multiple connected nodes: repro.mp4 |
4 tasks
github-project-automation
bot
moved this from 👁️ Code review
to 🟢 Accepted
in Issues Board
|
Ilya Bogdanov reports a new STANDUP for the provided date (2024-09-02): Progress: Investigated and fixed the issue with nodes deletion. Also disabled the broken record button. It should be finished by 2024-09-02. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Sometimes when deleting multiple components, some components are only partially deleted, and remain in the graph in a non-functional state.
I think this is probably related to the
Changed the client-id because another client seems to be using it.that appears in the logs when multiple components are deleted.(Reported by @jdunkerley; I have been able to reproduce it once, but not since)
The text was updated successfully, but these errors were encountered: