Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add indicator on nodes with warnings #9125

Closed
somebody1234 opened this issue Feb 21, 2024 · 6 comments · Fixed by #9160
Closed

Add indicator on nodes with warnings #9125

somebody1234 opened this issue Feb 21, 2024 · 6 comments · Fixed by #9160
Assignees
@somebody1234
Labels
-gui d-easy Difficulty: little prior knowledge required p-medium Should be completed in the next few sprints s-info-needed Status: more information needed from submitter x-new-feature Type: new feature request
Milestone
Beta Release

Comments

@somebody1234
Copy link
Contributor

somebody1234 commented Feb 21, 2024 •
edited
Loading

The UI should (?) match with the existing orange border present on GUI1.
@somebody1234 somebody1234 added d-easy Difficulty: little prior knowledge required p-high Should be completed in the next sprint -gui labels Feb 21, 2024
@somebody1234
Copy link
Contributor Author

pinging @AdRiley as a heads up.
(@ anyone - feel free to edit the description to be clearer, and/or include screenshots.)

@AdRiley AdRiley added this to the Beta Release milestone Feb 21, 2024
@farmaazon
Copy link
Contributor

I'm not sure if we need strictly orange border - maybe just warn sign next to node? We plan making icons for errors too: #8677

@farmaazon farmaazon added p-medium Should be completed in the next few sprints and removed p-high Should be completed in the next sprint labels Feb 21, 2024
@AdRiley
Copy link
Member

AdRiley commented Feb 21, 2024

Do we need a design? I guess the user requirement is to be able to see a component has warnings even when the component is not hovered or selected. And then hover/select shows you the warning.

@farmaazon farmaazon added s-info-needed Status: more information needed from submitter x-new-feature Type: new feature request labels Feb 22, 2024
@somebody1234
Copy link
Contributor Author

yeah...
... just tried adding a border around the node. while it technically works, it seems to be very difficult to get it to render below the edges.

@somebody1234 somebody1234 changed the title Add orange border on nodes with warnings Add indicator on nodes with warnings Feb 23, 2024
@somebody1234 somebody1234 mentioned this issue Feb 23, 2024
Merged
5 tasks
@somebody1234 somebody1234 self-assigned this Feb 23, 2024
@somebody1234 somebody1234 moved this from ❓New to 👁️ Code review in Issues Board Feb 23, 2024
@farmaazon farmaazon moved this from 👁️ Code review to 📤 Backlog in Issues Board Feb 23, 2024
@farmaazon farmaazon moved this from 📤 Backlog to 🔧 Implementation in Issues Board Feb 23, 2024
@farmaazon
Copy link
Contributor

farmaazon commented Feb 23, 2024 •
edited
Loading

We will go with the icon, as it's easier than making a working border.

Soon new icons will be merged. We should display them with the following colors (ignore the trash bin)

Image

@farmaazon
Copy link
Contributor

Also info from @jdunkerley:

it should appear to the left of the node, to the left of the menu if shown

@farmaazon farmaazon mentioned this issue Feb 26, 2024
Closed
@farmaazon farmaazon moved this from 🔧 Implementation to 🟢 Accepted in Issues Board Mar 4, 2024
@mergify mergify bot closed this as completed in #9160 Mar 4, 2024
mergify bot pushed a commit that referenced this issue Mar 4, 2024
@somebody1234
Add Warning indicator. (#9160)
b4cea52 
- Close #9125
- Display the new warning icon to the left of the node, when the node is not being hovered over.

# Important Notes
None
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@somebody1234 somebody1234

Labels
-gui d-easy Difficulty: little prior knowledge required p-medium Should be completed in the next few sprints s-info-needed Status: more information needed from submitter x-new-feature Type: new feature request
Projects
Issues Board
Archived in project
Milestone
Beta Release
Development

Successfully merging a pull request may close this issue.

Add Warning indicator. enso-org/enso
3 participants
@AdRiley @farmaazon @somebody1234