Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an icon for Error and Panic when shown on a Component #8677

Closed
AdRiley opened this issue Jan 4, 2024 · 3 comments · Fixed by #9633
Closed

Add an icon for Error and Panic when shown on a Component #8677

AdRiley opened this issue Jan 4, 2024 · 3 comments · Fixed by #9633
Assignees
Labels
-gui d-easy Difficulty: little prior knowledge required p-medium Should be completed in the next few sprints x-new-feature Type: new feature request
Milestone

Comments

@AdRiley
Copy link
Member

AdRiley commented Jan 4, 2024

When an error or panic is shown on a component, we should also display an icon to allow for easier distinguishing between the 2.

The icon should be shown in the same place as the warning icon. The error message should be always visible only on the node causing it.

e.g. this situation:
image

@AdRiley AdRiley added the -gui label Jan 4, 2024
@github-project-automation github-project-automation bot moved this to ❓New in Issues Board Jan 4, 2024
@farmaazon farmaazon added d-easy Difficulty: little prior knowledge required p-medium Should be completed in the next few sprints x-new-feature Type: new feature request labels Jan 4, 2024
@farmaazon farmaazon moved this from ❓New to 📤 Backlog in Issues Board Jan 4, 2024
@AdRiley AdRiley added this to the Beta Release milestone Feb 26, 2024
@farmaazon
Copy link
Contributor

  • We need new icon for panic @AdRiley. The icon for error will be already there.
  • We probably need more info about stacktraces from the engine (for Dataflow errors) to implement it properly. We can apply some heuristic (like: check if my error is exactly the same as some input's one). Then create a task/discussion with engine.

@AdRiley
Copy link
Member Author

AdRiley commented Mar 15, 2024

Added panic icon to Figma.

@kazcw kazcw self-assigned this Apr 3, 2024
@enso-bot
Copy link

enso-bot bot commented Apr 4, 2024

Keziah Wesley reports a new STANDUP for today (2024-04-03):

Progress: Started error-display changes. It should be finished by 2024-04-05.

Next Day: Next day I will be working on the #8677 task. Same task

@kazcw kazcw linked a pull request Apr 4, 2024 that will close this issue
5 tasks
@kazcw kazcw moved this from 📤 Backlog to 👁️ Code review in Issues Board Apr 4, 2024
@mergify mergify bot closed this as completed in #9633 Apr 5, 2024
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Apr 5, 2024
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-gui d-easy Difficulty: little prior knowledge required p-medium Should be completed in the next few sprints x-new-feature Type: new feature request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants