Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsetting arguments #8267

Closed
Tracked by #7685
farmaazon opened this issue Nov 9, 2023 · 0 comments
Closed
Tracked by #7685

Unsetting arguments #8267

farmaazon opened this issue Nov 9, 2023 · 0 comments
Assignees
@Frizi
Labels
-gui d-intermediate Difficulty: some prior knowledge required p-medium Should be completed in the next few sprints

Comments

@farmaazon
Copy link
Contributor

farmaazon commented Nov 9, 2023 •
edited
Loading

To be done after #8258

There are some cases, where we want to be able to unset a method argument:

  1. When value is unselected in drop-down
  2. When the connection to argument is detached.

In these cases, the argument should be removed from the code. Some positional arguments may turn named arguments in the process - see GUI1 implementation for details.
@github-project-automation github-project-automation bot moved this to ❓New in Issues Board Nov 9, 2023
@farmaazon farmaazon mentioned this issue Nov 9, 2023
Closed
@farmaazon farmaazon added d-intermediate Difficulty: some prior knowledge required p-medium Should be completed in the next few sprints -gui labels Nov 9, 2023
@farmaazon farmaazon moved this from ❓New to 📤 Backlog in Issues Board Nov 9, 2023
@farmaazon farmaazon moved this from 📤 Backlog to 🔧 Implementation in Issues Board Dec 13, 2023
@Frizi Frizi mentioned this issue Dec 15, 2023
Merged
5 tasks
@farmaazon farmaazon moved this from 🔧 Implementation to 👁️ Code review in Issues Board Dec 15, 2023
mergify bot pushed a commit that referenced this issue Dec 22, 2023
@Frizi
[GUI2] Widget update handlers (#8545)
56657cc 
Fixes #8258 #8267

Added a generic way of setting a new expression value from within a widget, and ability to intercept those update calls from the child widgets. Used that to implement function argument assignment and clearing.

https://github.com/enso-org/enso/assets/919491/513b823b-eb2c-45d8-88ac-4971ba061c59
@farmaazon farmaazon moved this from 👁️ Code review to 🟢 Accepted in Issues Board Dec 22, 2023
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Frizi Frizi

Labels
-gui d-intermediate Difficulty: some prior knowledge required p-medium Should be completed in the next few sprints
Projects
Issues Board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Frizi @farmaazon