-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accepting value on argument placeholders #8258
Comments
To do:
|
Paweł Grabarz reports a new STANDUP for yesterday (2023-11-22): Progress: Designing an unified API for setting widget values, so that argument setting can be handled by the top-level function application widget. It should be finished by 2023-11-27. |
Paweł Grabarz reports a new 🔴 DELAY for yesterday (2023-12-13): Summary: There is 17 days delay in implementation of the Accepting value on argument placeholders (#8258) task. Delay Cause: Issues and complications caused by editing code without proper AST updates implementation. |
Paweł Grabarz reports a new STANDUP for yesterday (2023-12-13): Progress: Fixed remaining bugs in the argument update code. The connection and disconnection seems to be more robust now, and all remaining issues should be fixed once it is migrated to AST updates. It should be finished by 2023-12-14. |
Fixes #8258 #8267 Added a generic way of setting a new expression value from within a widget, and ability to intercept those update calls from the child widgets. Used that to implement function argument assignment and clearing. https://github.com/enso-org/enso/assets/919491/513b823b-eb2c-45d8-88ac-4971ba061c59
Paweł Grabarz reports a new STANDUP for the provided date (2023-12-14): Progress: Resolved conflicts with latest develop and fixed build issues. PR submitted for review. It should be finished by 2023-12-22. |
Paweł Grabarz reports a new STANDUP for the provided date (2023-12-15): Progress: Reviewed GUI entrypoint changes. Started addressing review comments. It should be finished by 2023-12-22. |
Paweł Grabarz reports a new STANDUP for the provided date (2023-12-18): Progress: Reviewed AST update code. Continuing addressing review comments. It should be finished by 2023-12-22. |
Paweł Grabarz reports a new STANDUP for the provided date (2023-12-19): Progress: Addressed PR review, started adapting widget update code to new AST based updates. It should be finished by 2023-12-22. |
Paweł Grabarz reports a new STANDUP for the provided date (2023-12-20): Progress: Continuing with AST based widget updates, but so far mostly stumbling on bugs with AST manipulation code. After all decided to leave the PR for merging with text-based edits, and attempt this again after AST edits are more robust. It should be finished by 2023-12-22. |
To be done after #8257 and #8236
Having the arg placeholders, setting a value on them should work - both by widget and by connecting to the placeholder.
The exact behavior should be the same as in the old GUI.
The text was updated successfully, but these errors were encountered: