Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accepting value on argument placeholders #8258

Closed
Tracked by #7685
farmaazon opened this issue Nov 8, 2023 · 9 comments · Fixed by #8545
Closed
Tracked by #7685

Accepting value on argument placeholders #8258

farmaazon opened this issue Nov 8, 2023 · 9 comments · Fixed by #8545
Assignees
Labels
-gui d-hard Difficulty: significant prior knowledge required p-medium Should be completed in the next few sprints

Comments

@farmaazon
Copy link
Contributor

farmaazon commented Nov 8, 2023

To be done after #8257 and #8236

Having the arg placeholders, setting a value on them should work - both by widget and by connecting to the placeholder.

The exact behavior should be the same as in the old GUI.

@github-project-automation github-project-automation bot moved this to ❓New in Issues Board Nov 8, 2023
@farmaazon farmaazon mentioned this issue Nov 8, 2023
@farmaazon farmaazon added d-hard Difficulty: significant prior knowledge required p-medium Should be completed in the next few sprints -gui labels Nov 8, 2023
@farmaazon farmaazon changed the title Accepting setting on argument placeholders Accepting AST on argument placeholders Nov 9, 2023
@farmaazon farmaazon changed the title Accepting AST on argument placeholders Accepting value on argument placeholders Nov 9, 2023
@farmaazon farmaazon moved this from ❓New to 📤 Backlog in Issues Board Nov 9, 2023
@farmaazon
Copy link
Contributor Author

farmaazon commented Nov 16, 2023

To do:

  • Modify AST adding a new layer of application
  • Argument should be named if needed (if it's not very next arg of function call).
  • Simplify the following named arguments if applicable (when we fill "a hole" in the provided arguments).
  • Refactor connecting: the AST changes should be handled by widgets, not globally by connection logic.

@Frizi Frizi moved this from 📤 Backlog to 🔧 Implementation in Issues Board Nov 22, 2023
@enso-bot
Copy link

enso-bot bot commented Nov 23, 2023

Paweł Grabarz reports a new STANDUP for yesterday (2023-11-22):

Progress: Designing an unified API for setting widget values, so that argument setting can be handled by the top-level function application widget. It should be finished by 2023-11-27.

@enso-bot
Copy link

enso-bot bot commented Dec 14, 2023

Paweł Grabarz reports a new 🔴 DELAY for yesterday (2023-12-13):

Summary: There is 17 days delay in implementation of the Accepting value on argument placeholders (#8258) task.
It will cause 17 days delay for the delivery of this weekly plan.

Delay Cause: Issues and complications caused by editing code without proper AST updates implementation.

@enso-bot
Copy link

enso-bot bot commented Dec 14, 2023

Paweł Grabarz reports a new STANDUP for yesterday (2023-12-13):

Progress: Fixed remaining bugs in the argument update code. The connection and disconnection seems to be more robust now, and all remaining issues should be fixed once it is migrated to AST updates. It should be finished by 2023-12-14.

@farmaazon farmaazon moved this from 🔧 Implementation to 👁️ Code review in Issues Board Dec 15, 2023
@mergify mergify bot closed this as completed in #8545 Dec 22, 2023
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Dec 22, 2023
mergify bot pushed a commit that referenced this issue Dec 22, 2023
Fixes #8258 #8267

Added a generic way of setting a new expression value from within a widget, and ability to intercept those update calls from the child widgets. Used that to implement function argument assignment and clearing.

https://github.com/enso-org/enso/assets/919491/513b823b-eb2c-45d8-88ac-4971ba061c59
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board Jan 4, 2024
@enso-bot
Copy link

enso-bot bot commented Jan 19, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2023-12-14):

Progress: Resolved conflicts with latest develop and fixed build issues. PR submitted for review. It should be finished by 2023-12-22.

@enso-bot
Copy link

enso-bot bot commented Jan 19, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2023-12-15):

Progress: Reviewed GUI entrypoint changes. Started addressing review comments. It should be finished by 2023-12-22.

@enso-bot
Copy link

enso-bot bot commented Jan 19, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2023-12-18):

Progress: Reviewed AST update code. Continuing addressing review comments. It should be finished by 2023-12-22.

@enso-bot
Copy link

enso-bot bot commented Jan 19, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2023-12-19):

Progress: Addressed PR review, started adapting widget update code to new AST based updates. It should be finished by 2023-12-22.

@enso-bot
Copy link

enso-bot bot commented Jan 19, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2023-12-20):

Progress: Continuing with AST based widget updates, but so far mostly stumbling on bugs with AST manipulation code. After all decided to leave the PR for merging with text-based edits, and attempt this again after AST edits are more robust. It should be finished by 2023-12-22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-gui d-hard Difficulty: significant prior knowledge required p-medium Should be completed in the next few sprints
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants