Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use Material Light theme" #173

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Conversation

wjt
Copy link
Member

@wjt wjt commented Aug 10, 2023

This reverts commit 5419378.

While this makes the "your webview is too old" dialog ugly, it also
restores the previous titlebar colour on Chrome OS.

This revert should be reverted in future together with a change to set
the titlebar colour.

Fixes #172

This reverts commit 5419378.

While this makes the "your webview is too old" dialog ugly, it also
restores the previous titlebar colour on Chrome OS.

This revert should be reverted in future together with a change to set
the titlebar colour.

Fixes #172
Copy link
Member

@dbnicholson dbnicholson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a custom theme is going to be more work since it's not supported by p4a, so I'm just going to merge this for now.

@dbnicholson dbnicholson merged commit fde32c6 into develop Aug 14, 2023
@dbnicholson dbnicholson deleted the 172-revert-theme-change branch August 14, 2023 16:39
@erikos
Copy link

erikos commented Aug 15, 2023

The app had been built but not uploaded with this change, so I kicked off the Jenkins job.
Screenshot 2023-08-15 1 17 53 PM

Ladybird 6.32-381 has the change.

@erikos
Copy link

erikos commented Aug 15, 2023

Screenshot 2023-08-15 1 43 52 PM

Verified in Ladybird 6.32-381.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App titlebar in Android is grey instead of black
3 participants