Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make webview-age dialog less ugly again #174

Open
wjt opened this issue Aug 10, 2023 · 5 comments · May be fixed by #176
Open

Make webview-age dialog less ugly again #174

wjt opened this issue Aug 10, 2023 · 5 comments · May be fixed by #176
Labels
enhancement New feature or request

Comments

@wjt
Copy link
Member

wjt commented Aug 10, 2023

In #173 we reverted a theme change that had been made to make the "your webview is too old" dialog not ugly. This is because the theme change brought with it a titlebar colour change.

To have the best of both world, we can define a theme that derives from the Material theme and only overrides the statusbar/titlebar colour. For extra credit, we could also explore using the setStatusBarColor API to adjust the titlebar colour to fit the content within.
@wjt wjt mentioned this issue Aug 10, 2023
Closed
@wjt wjt added the enhancement New feature or request label Aug 11, 2023
@dbnicholson
Copy link
Member

You can also specify the theme for the dialog, but that would only be for the one dialog we load. I don't know what would happen for dialogs spawned by other means.

@dbnicholson
Copy link
Member

I'm going to see about defining a custom theme derived from Material with a black status bar. We'll see if p4a makes that possible, though. I'm worried that calling setStatusBar will happen too late with p4a since we don't actually run our own code until well after the app has been initialized.

@dbnicholson
Copy link
Member

Not suprisingly, p4a has no support for custom resource values, so a custom theme will require adding support there.

dbnicholson added a commit that referenced this issue Aug 14, 2023
@dbnicholson
Add custom theme derived from Material Light
e6f1b7a 
This restores the attempt to use Material Light except that it overrides
the status bar to black as the previous theme did. A custom theme using
a resource value file is needed for that.

This depends on the new `--res-values` option in python-for-android
v2022.09.04-endless11.

Fixes: #174
@dbnicholson dbnicholson linked a pull request Aug 14, 2023 that will close this issue
Draft
@dbnicholson
Copy link
Member

Ready in endlessm/python-for-android#19 and #176. The p4a side needs to be merged and released first.

@dbnicholson
Copy link
Member

I tagged the p4a changes so they could be used. We discussed in the team meeting today that it would be preferable not to touch the appearance anymore right now before we take a break from this work. I moved the theme change back to a draft so it doesn't get merged right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Material Light theme with black status bar endlessm/kolibri-installer-android
2 participants
@wjt @dbnicholson