Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ability to decrypt ssl key file #808

Merged
merged 22 commits into from
Oct 12, 2020
Merged

Conversation

euri10
Copy link
Member

@euri10 euri10 commented Oct 7, 2020

Should be merge after #807 as it builds on it

Built on #776 , added tests and changed what @florimondmanca wanted

The encrypted key fixture is stolen from https://github.com/urllib3/urllib3/blob/master/dummyserver/server.py#L217-L226 as advised by trio wizards !

@euri10
Copy link
Member Author

euri10 commented Oct 12, 2020

Now #807 is merged this one is rather easy !

Copy link
Member

@cdeler cdeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is fine, apart one comment (which you can fix if you agree with my remark)

tests/conftest.py Show resolved Hide resolved
@euri10
Copy link
Member Author

euri10 commented Oct 12, 2020

Fixes #581

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants