Refactor ssl tooling using trustme #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euri10
commented
Oct 7, 2020
| @@ -11,7 +11,7 @@ def run(sockets): | |||
| pass | |||
|
|
|||
|
|
|||
| def test_watchgodreload(certfile_and_keyfile): | |||
| def test_watchgodreload(tls_ca_certificate_pem_path, tls_ca_certificate_private_key_path): | |||
There was a problem hiding this comment.
have to say I'm surprised I had to modify this since those fixtures are not used in the test, I think we shoud remove them, letting it that way just in case I missed something
|
much appreciated @cdeler ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes hardcoded values for certificates / private keys and uses fixtures based on the trustme library
I think it's worthy addition as a preliminary work towards better tests for #776 and maybe in anticipation of a resolution of #806
It also adds a test that shows how to use a combined key and certificate (
test_run_chain)