Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward gunicorn reload parameter to uvicorn worker #1193

Closed
wants to merge 1 commit into from
Closed

Forward gunicorn reload parameter to uvicorn worker #1193

wants to merge 1 commit into from

Conversation

Kludex
Copy link
Member

@Kludex Kludex commented Sep 23, 2021

Basically a copy/paste from benoitc/gunicorn#2339 (comment) made by @jvasi

This solution pops up the following on reload:

[INFO] Error while closing socket [Errno 9] Bad file descriptor

Notes:

  • I haven't investigated the issue above.
  • I'm not sure if I want this to be merged, as it can be extended the way it was in the mentioned comment.

@Kludex Kludex added the hold Don't merge yet label Sep 23, 2021
@Kludex
Copy link
Member Author

Kludex commented Jan 6, 2022

This is not a satisfatible solution considering the reload system gunicorn uses. They make use of SIGHUP on the reload, and we should leverage that here.

@Kludex Kludex closed this Jan 6, 2022
@Kludex
Copy link
Member Author

Kludex commented Jan 6, 2022

SIGHUP is not available on Windows, but gunicorn doesn't run on Windows anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold Don't merge yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants