Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if reload can be done via SIGHUP, or forward --reload flag. #7

Open
Kludex opened this issue Mar 30, 2024 · 1 comment
Open

Comments

@Kludex
Copy link
Owner

Kludex commented Mar 30, 2024

No description provided.

@Kludex Kludex mentioned this issue Mar 30, 2024
4 tasks
@iamkhav
Copy link

iamkhav commented Jun 26, 2024

Hey @Kludex,
I want to help with this issue since having this would make Uvicorn obsolete for local dev for me (probably) 😄

SIGHUP can be used to reload workers but as far as I understand, every worker has a reloader instance and sending SIGHUP from the reloader would send multiple signals to the master process if #workers > 1.

I know that Uvicorn itself doesn't support multiple workers when using --reload, is this something that we would want to enforce for local dev then?

Otherwise, what's wrong with this solution that you previously proposed? encode/uvicorn#1193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants