Add markdown and PyYAML to tox test requirements #2133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tomchristie will test that as a possible fix. Open a new PR if it works? |
|
As part of this is fine. |
|
So after a while struggling with this, I managed to fix the failing tests without having to change the renderer or parser. Still not sure if that's correct. |
|
Looks right to me. |
tomchristie
added a commit
that referenced
this pull request
Nov 25, 2014
Add markdown and PyYAML to tox test requirements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't think there was a reason for not having
markdownandPyYAMLadded to the test dependencies intox.in. Figured it must have been forgotten a while back.There are tests failing on Python 3 and the YAML support, but probably not many have noticed , my guess is not many people actually using YAML with DRF and tests being skipped because of missing requirements.
I'm still not sure how to correctly fix the issue, but I think the
YAMLRenderershould be returning a string not bytes in Python 3.As per this comment, I also started extracting the YAML parser and renderer as a third party package.
https://github.com/jpadilla/django-rest-framework-yaml