Oauth as package #2076
Oauth as package #2076
Conversation
…ework into oauth_as_package Conflicts: .travis.yml
|
@tomchristie I could actually rebase this to remove the nasty merge commit, but I didn't want to alter other people's commits. Let me know if you prefer that. |
|
@Geekfish Nope, fine as is. Thank you! |
|
So next question of course is maintainership. Who is going to look after the old OAuth package. I believe the owner if the previous PR expressed willingness, but I've not seen concrete evidence of ongoing commitment. Any takers or thoughts? |
|
An alternative might be to have a rest framework github org that we use for this sort of thing. The regular maintainers could have access, but we don't need to prioritise external issues as higly as the core package. |
|
Having a DRF organization might be a good idea, but what other package would we include there? If the owners of the last pull requests can't mantain it, I'm willing to step up immediately and take care of it. Also, how about extracting the token auth as a third party app as well? — http://jpadilla.com / @jpadilla_ On Sun, Nov 16, 2014 at 2:25 PM, Tom Christie [email protected]
|
|
I don't mind the token auth as it doesn't have any package dependancies. We could call it out more strongly in the docs as just a basic minimal implementation. The XML and yaml support oughta get booted out to third party really. |
|
I'm standby to take this(oauth package) on and get it done. Not sure how long I should wait thought. @tomchristie regarding the xml and yaml renderers, thinking about taking what we're doing on #2043 to do those as third party packages and see how it goes. |
|
@jpadilla I'd say just assume you'll be the best person to maintain it and run from there (don't recall who original volunteer was or how explicitly we've checked with them?). Either ways we'll time it as 3.1 so no big hurry, but if you have a link able repo up and it has the docs ported over etc, then we can just hit go whenever we're ready. |
|
Just created a new package for this, django-rest-framework-oauth. It's already published to PyPI as well. Docs are linked here. Next steps? |
|
Looks good. Maybe a shout out on the discussion group inviting folks using the current built-in to try migrating to the external package? See if we can get some feedback that it's seemless? |
|
If anyone is interested in giving it a try, feedback is welcome. Also just sent a message on the discussion group. |
|
@tomchristie, I'm sorry that I've been too busy to work on that package. I would be happy to help maintain it, but I realize that I don't have the time to manage it myself. If someone would like access to the repository or PyPI package please let me know. |
|
Not a problem @jlafon, totally appreciate the update :) |
|
Okay, last time to update so it merges cleanly (again, sorry) after that I'm merging this in, then keeping 3.1 clean against 3.0 will be my responsibility. :p |
|
On it. |
|
Now superseeded by #2156. Thanks for the group effort folks! |
Same as #1840, addressing #1840, just brought up to date with v3.1 so that it can be merged.