Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1147 - Exhaust temperature always zero on GB125/MC110/RC310 #1150

Merged
merged 3 commits into from
Apr 2, 2023
Merged

Fix #1147 - Exhaust temperature always zero on GB125/MC110/RC310 #1150

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
982a43b
Fix Exhaust Temperature for Logano plus GB125 with Logamatic MC110.
minusdreidb Mar 26, 2023
5c59a20
Accept exhaustTemp_ update from telegram 0xE5 if value is unequal zero.
minusdreidb Mar 27, 2023
e2fec03
Use exhaust temperature from 0xe4, remove from 0xe5 until verified, c…
minusdreidb Apr 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/devices/boiler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1032,6 +1032,8 @@ void Boiler::process_UBAMonitorFastPlus(std::shared_ptr<const Telegram> telegram
//has_update(telegram, temperatur_, 13); // unknown temperature
//has_update(telegram, temperatur_, 27); // unknown temperature

has_update(telegram, exhaustTemp_, 31);

// read 3 char service code / installation status as appears on the display
if ((telegram->message_length > 3) && (telegram->offset == 0)) {
char serviceCode[4] = {0};
Expand Down Expand Up @@ -1096,7 +1098,13 @@ void Boiler::process_UBAMonitorSlowPlus(std::shared_ptr<const Telegram> telegram
has_bitupdate(telegram, ignWork_, 2, 3);
has_bitupdate(telegram, heatingPump_, 2, 5);
has_bitupdate(telegram, wwCirc_, 2, 7);
has_update(telegram, exhaustTemp_, 6);

/* Update exhaust temperature if it is unequal 0 */
const uint8_t exhaustTempOffset{6};
uint16_t exhaustTemp{0};
if (telegram->read_value(exhaustTemp, exhaustTempOffset))
has_update(telegram, exhaustTemp_, exhaustTempOffset);

has_update(telegram, burnStarts_, 10, 3); // force to 3 bytes
has_update(telegram, burnWorkMin_, 13, 3); // force to 3 bytes
has_update(telegram, burn2WorkMin_, 16, 3); // force to 3 bytes
Expand Down