Fix #1147 - Exhaust temperature always zero on GB125/MC110/RC310 #1150
Conversation
Exhaust Temperature was always zero prior to fix. On the setup - Logano plus GB125 with Logamatic MM110 (SW-Version 02.10) - Logamatic RC310 (SW-Version 74.03) - MM100 (SW-Version 24.05) the exhaust temperature ist found in telegram type 0xe4 at offset 31. The original location in telegram 0xe5, offset 6 is always zero.
minusdreidb
changed the title
There was a problem hiding this comment.
@proddy I'm not sure what is the right way to handle it. The exhaustTemp in E4 is now verified by @minusdreidb . The temp in E5 was just a guess and is maybe something different.
I think it's better to remove the reading in E5 and check again if users have the E5 value and can verify what it is. We can leave a comment in E5 with reference to issue #1147.
If we really want read both, @minusdreidb should add the same logic to E4-telegram to avoid toggling between 0 and value. But if both telegrams report a nonzero value we also have toggling.
I agree. I don't really like conditional statements in the processing of the EMS telegrams. Let's remove E5 and see who starts complaining. @minusdreidb are you ok to adjust this PR? |
|
I'm OK with adjusting it, but it will have to wait for the weekend :-).
…On 28 March 2023 20:32:59 CEST, Proddy ***@***.***> wrote:
> @proddy I'm not sure what is the right way to handle it. The exhaustTemp in E4 is now verified by @minusdreidb . The temp in E5 was just a guess and is maybe something different. I think it's better to remove the reading in E5 and check again if users have the E5 value and can verify what it is. We can leave a comment in E5 with reference to issue #1147. If we really want read both, @minusdreidb should add the same logic to E4-telegram to avoid toggling between 0 and value. But if both telegrams report a nonzero value we also have toggling.
I agree. I don't really like conditional statements in the processing of the EMS telegrams. Let's remove E5 and see who starts complaining. @minusdreidb are you ok to adjust this PR?
|
|
@proddy I made the changes and updated the PR. |
|
ok with me. @MichaelDvP ? |
Yes. |
Fix always zero exhaust temperature reading by adding location telegram 0xe4, offset 31 as an additional source for the exhaust temp. and update from 0xe5 only if the value is unequal 0.