Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have create_release.py push the new branch automatically #1255

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Jul 10, 2023

Having used this script for a while now I'm not sure there is any point if leaving this last step as a manual push.

Having used this script for a while now I'm not sure there is any
point if leaving this last step as a manual push.
Copy link
Member

@dschuff dschuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a doc that needs to be updated too?

@sbc100
Copy link
Collaborator Author

sbc100 commented Jul 10, 2023

Done in emscripten-core/emscripten#19827

@sbc100 sbc100 merged commit 2d3b8a7 into main Jul 10, 2023
@sbc100 sbc100 deleted the create_release branch July 10, 2023 21:03
shlomif pushed a commit to shlomif/emsdk that referenced this pull request Sep 29, 2023
…core#1255)

Having used this script for a while now I'm not sure there is any
point if leaving this last step as a manual push.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants