Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create_release.py: Push resulting branch to origin #19827

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Jul 10, 2023

Also, set the upstream when creating the new branch.

See emscripten-core/emsdk#1255

Copy link
Member

@dschuff dschuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, so I just realized that I use the emscripten repo inside an emscripten-releases checkout. this means its 'origin' is actually chromium.googlesource.com/emscripten rather than github (I just have another remote to push to github). So this won't work for me.
One option would be to make this overridable via an env var or something. but let me also check whether gclient still works if I rename my origin remote.

@sbc100
Copy link
Collaborator Author

sbc100 commented Jul 10, 2023

ah, so I just realized that I use the emscripten repo inside an emscripten-releases checkout. this means its 'origin' is actually chromium.googlesource.com/emscripten rather than github (I just have another remote to push to github). So this won't work for me. One option would be to make this overridable via an env var or something. but let me also check whether gclient still works if I rename my origin remote.

Yes, maybe see if you can set github as your origin. Failing that we can add a flag I guess? Or check the origin URL?

@dschuff
Copy link
Member

dschuff commented Jul 10, 2023

OK, yeah gclient sync seems to work fine with the github remote as 'origin'.

tools/maint/create_release.py Show resolved Hide resolved
Also, set the upstream when creating the new branch.
@sbc100 sbc100 merged commit 2bfe7cb into main Jul 10, 2023
@sbc100 sbc100 deleted the create_release branch July 10, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants