-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(admin/ui): admin dashboard #1231
Merged
Merged
Changes from 13 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
477eff2
ref: split add from edit
theus77 f52c97d
ref: breadcrumb
theus77 d20b669
ref: add
theus77 6e90f48
ref: edit
theus77 dfcf367
fix: breadcrumb
theus77 10ba5a9
fix: no icon no color
theus77 99f336a
fix: dashboard type's icons
theus77 1429f20
ref: dashboard template type
theus77 47f20ac
Merge branch '6.x' into ref/dashboard
theus77 3911e58
chore: phpcs
theus77 4ab09db
Merge remote-tracking branch 'theus77/ref/dashboard' into ref/dashboard
theus77 58c8b8e
Merge branch '6.x' into ref/dashboard
theus77 63bec4e
Merge branch '6.x' into ref/dashboard
theus77 a318467
Merge branch '6.x' into ref/dashboard
theus77 d70e391
fix: the template is defined in the twig (with the dashboard name wic…
theus77 7eae314
ref: better trans key
theus77 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 changes: 26 additions & 10 deletions
36
EMS/admin-ui-bundle/templates/bootstrap5/dashboard/abstract.html.twig
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,28 @@ | ||
{% extends '@EMSAdminUI/bootstrap5/base/admin.html.twig' %} | ||
{% trans_default_domain 'emsco-twigs' %} | ||
{% extends '@EMSAdminUI/bootstrap5/template/card.html.twig' %} | ||
|
||
{% block breadcrumb %} | ||
<ol class="breadcrumb float-sm-end"> | ||
<li class="breadcrumb-item"><a href="{{ path('emsco_dashboard_admin_index') }}"><i class="{{ 'view.icon.class.dashboard'|trans }}"></i> {{ 'dashboard.menu'|trans }}</a></li> | ||
{% block breadcrumb_items %}{% endblock breadcrumb_items %} | ||
</ol> | ||
{% endblock %} | ||
{% block form %} | ||
<div class="row"> | ||
{{ form_row(form.name) }} | ||
<div class="clearfix"></div> | ||
{{ form_row(form.role) }} | ||
<div class="clearfix"></div> | ||
{{ form_row(form.icon) }} | ||
<div class="clearfix"></div> | ||
{{ form_row(form.label) }} | ||
<div class="clearfix"></div> | ||
{{ form_row(form.color) }} | ||
<div class="clearfix"></div> | ||
{{ form_row(form.sidebarMenu) }} | ||
<div class="clearfix"></div> | ||
{{ form_row(form.notificationMenu) }} | ||
<div class="clearfix"></div> | ||
{% if form.type is defined %} | ||
{{ form_row(form.type) }} | ||
<div class="clearfix"></div> | ||
{% endif %} | ||
{% if form.options is defined %} | ||
{{ form_row(form.options) }} | ||
{% endif %} | ||
</div> | ||
{% endblock form %} | ||
|
||
{% block pagetitle %}{{ block('title') }}{% endblock %} | ||
{% block subtitle %}<small>{{ 'dashboard.tagline'|trans }}</small>{% endblock %} |
5 changes: 1 addition & 4 deletions
5
EMS/admin-ui-bundle/templates/bootstrap5/dashboard/add.html.twig
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1 @@ | ||
{% extends '@EMSAdminUI/bootstrap5/dashboard/form.html.twig' %} | ||
{% trans_default_domain 'emsco-twigs' %} | ||
|
||
{% block title %}{{ 'dashboard.add.title'|trans }}{% endblock %} | ||
{% extends '@EMSAdminUI/bootstrap5/dashboard/abstract.html.twig' %} |
5 changes: 1 addition & 4 deletions
5
EMS/admin-ui-bundle/templates/bootstrap5/dashboard/edit.html.twig
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1 @@ | ||
{% extends '@EMSAdminUI/bootstrap5/dashboard/form.html.twig' %} | ||
{% trans_default_domain 'emsco-twigs' %} | ||
|
||
{% block title %}{{ 'dashboard.edit.title'|trans({'%label%': dashboard.label}) }}{% endblock %} | ||
{% extends '@EMSAdminUI/bootstrap5/dashboard/abstract.html.twig' %} |
50 changes: 0 additions & 50 deletions
50
EMS/admin-ui-bundle/templates/bootstrap5/dashboard/form.html.twig
This file was deleted.
Oops, something went wrong.
17 changes: 0 additions & 17 deletions
17
EMS/admin-ui-bundle/templates/bootstrap5/dashboard/index.html.twig
This file was deleted.
Oops, something went wrong.
24 changes: 5 additions & 19 deletions
24
EMS/admin-ui-bundle/templates/bootstrap5/dashboard/services/error.html.twig
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,22 +1,8 @@ | ||
{% extends '@EMSAdminUI/bootstrap5/base/admin.html.twig' %} | ||
{% trans_default_domain 'emsco-twigs' %} | ||
|
||
{% block breadcrumb %} | ||
<ol class="breadcrumb float-sm-end"> | ||
<li class="breadcrumb-item"><a href="{{ path('emsco_dashboard', {name: dashboard.name}) }}"><i class="{{ dashboard.icon }}"></i> {{ dashboard.label }}</a></li> | ||
</ol> | ||
{% endblock %} | ||
|
||
{% block title %}{{ 'dashboard.exception.title'|trans({'%name%': dashboard.name}) }}{% endblock %} | ||
{% block pagetitle %}{{ block('title') }}{% endblock %} | ||
{% block subtitle %}{% endblock %} | ||
{% extends '@EMSAdminUI/bootstrap5/template/card.html.twig' %} | ||
|
||
{% block body %} | ||
<div class="row"> | ||
<div class="col-12"> | ||
<div class="card card-{{ theme_color }} card-outline card-body"> | ||
<pre>{{ exception.message }}</pre> | ||
</div> | ||
</div> | ||
</div> | ||
{% set content %} | ||
<pre>{{ exception.message }}</pre> | ||
{% endset %} | ||
{{ parent() }} | ||
{% endblock %} |
10 changes: 0 additions & 10 deletions
10
EMS/admin-ui-bundle/templates/bootstrap5/dashboard/services/template.html.twig
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -99,6 +99,9 @@ core: | |
other {There are # indexes} | ||
} | ||
version: 'Version {core} with Symfony {symfony}' | ||
dashboard: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I do not like the dashboard entry at root level. For me it needs to be in log.error or core.dashboard ? |
||
exception: | ||
title: 'An exception has been raised' | ||
field: | ||
alias: Alias | ||
available: Available | ||
|
@@ -323,6 +326,7 @@ type: | |
action {Create action} | ||
analyzer {Create analyzer} | ||
channel {Create channel} | ||
dashboard {Create dashboard} | ||
content_type {Create content type} | ||
form {Create form} | ||
job {Launch new job} | ||
|
@@ -333,6 +337,7 @@ type: | |
action {Edit action: {label}} | ||
analyzer {Edit analyzer: {label}} | ||
channel {Edit channel: {label}} | ||
dashboard {Edit dashboard: {label}} | ||
content_type {Edit content type: {label}} | ||
form {Edit form: {label}} | ||
other {Edit} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dashboard.exception.title ? I was expecting it only in the catch block ?