refactor(admin/ui): admin dashboard #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
theus77
commented
Feb 25, 2025
theus77
commented
| Q | A |
|---|---|
| Bug fix? | y |
| New feature? | n |
| BC breaks? | n |
| Deprecations? | y |
| Fixed tickets? | n |
| Documentation? | n |
Davidmattei
requested changes
Feb 26, 2025
| @@ -22,12 +25,24 @@ public function getResponse(Dashboard $dashboard): Response | |||
| $response->setContent($this->twig->render("@$this->templateNamespace/dashboard/services/template.html.twig", [ | |||
| 'dashboard' => $dashboard, | |||
| 'options' => $dashboard->getOptions(), | |||
| 'title' => t('dashboard.exception.title', [], 'emsco-core'), | |||
There was a problem hiding this comment.
dashboard.exception.title ? I was expecting it only in the catch block ?
| @@ -99,6 +99,9 @@ core: | |||
| other {There are # indexes} | |||
| } | |||
| version: 'Version {core} with Symfony {symfony}' | |||
| dashboard: | |||
There was a problem hiding this comment.
I do not like the dashboard entry at root level.
For me it needs to be in log.error or core.dashboard ?
…h is not a translation and can't be set here)
Davidmattei
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.