Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xcontrols): add skeleton #1278

Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/x-components/src/store/x.module.ts
Original file line number Diff line number Diff line change
@@ -35,7 +35,8 @@ export const RootXStoreModule: Module<XModuleState, any> = {
searchBox: null,
semanticQueries: null,
tagging: null,
url: null
url: null,
xcontrols: null
}),
namespaced: true
};
2 changes: 2 additions & 0 deletions packages/x-components/src/x-modules/x-modules.types.ts
Original file line number Diff line number Diff line change
@@ -19,6 +19,7 @@ import { SearchXModule } from './search/x-module';
import { SemanticQueriesXModule } from './semantic-queries/x-module';
import { TaggingXModule } from './tagging';
import { UrlXModule } from './url';
import { XControlsModule } from './xcontrols/x-module';

/**
* Gives each {@link XModule} a name, that can be used to retrieve then its value.
@@ -44,6 +45,7 @@ export interface XModulesTree {
semanticQueries: SemanticQueriesXModule;
tagging: TaggingXModule;
url: UrlXModule;
xcontrols: XControlsModule;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
xcontrols: XControlsModule;
experience-controls: XControlsModule;

}

/**
9 changes: 9 additions & 0 deletions packages/x-components/src/x-modules/xcontrols/config.types.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
/**
* Configuration options.
*
* @public
*/
export interface XControlsConfig {
numberOfCarousels: number;
resultsPerCarousels: number;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build is failing because of these empty files. Either remove them or make them export an empty object and then try the build again

Empty file.
Empty file.
Empty file.
Empty file.
21 changes: 21 additions & 0 deletions packages/x-components/src/x-modules/xcontrols/x-module.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
import { XModule } from '../x-modules.types';

/**
* Search {@link XModule} alias.
*
* @public
*/
export type XControlsModule = XModule<any>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export type XControlsModule = XModule<any>;
export type ExperienceControlsXModule = XModule<any>;


/**
* Search {@link XModule} implementation. This module is auto-registered as soon as you
* import any component from the `x-controls` entry point.
*
* @public
*/
export const xControlsXModule: XControlsModule = {
name: 'xcontrols',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: 'xcontrols',
name: 'experience-controls',

storeModule: {},
storeEmitters: {},
wiring: {}
};