-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(xcontrols): add skeleton #1278
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
/** | ||
* Configuration options. | ||
* | ||
* @public | ||
*/ | ||
export interface XControlsConfig { | ||
numberOfCarousels: number; | ||
resultsPerCarousels: number; | ||
} |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Build is failing because of these empty files. Either remove them or make them export an empty object and then try the build again |
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,21 @@ | ||||||
import { XModule } from '../x-modules.types'; | ||||||
|
||||||
/** | ||||||
* Search {@link XModule} alias. | ||||||
* | ||||||
* @public | ||||||
*/ | ||||||
export type XControlsModule = XModule<any>; | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
||||||
/** | ||||||
* Search {@link XModule} implementation. This module is auto-registered as soon as you | ||||||
* import any component from the `x-controls` entry point. | ||||||
* | ||||||
* @public | ||||||
*/ | ||||||
export const xControlsXModule: XControlsModule = { | ||||||
name: 'xcontrols', | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
storeModule: {}, | ||||||
storeEmitters: {}, | ||||||
wiring: {} | ||||||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.