feat(xcontrols): add skeleton #1278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ana Fernández Ostio <[email protected]>
CachedaCodes
suggested changes
Sep 12, 2023
| * | ||
| * @public | ||
| */ | ||
| export type XControlsModule = XModule<any>; |
There was a problem hiding this comment.
Suggested change
| export type XControlsModule = XModule<any>; | |
| export type ExperienceControlsXModule = XModule<any>; |
| * @public | ||
| */ | ||
| export const xControlsXModule: XControlsModule = { | ||
| name: 'xcontrols', |
There was a problem hiding this comment.
Suggested change
| name: 'xcontrols', | |
| name: 'experience-controls', |
| @@ -44,6 +45,7 @@ export interface XModulesTree { | |||
| semanticQueries: SemanticQueriesXModule; | |||
| tagging: TaggingXModule; | |||
| url: UrlXModule; | |||
| xcontrols: XControlsModule; | |||
There was a problem hiding this comment.
Suggested change
| xcontrols: XControlsModule; | |
| experience-controls: XControlsModule; |
There was a problem hiding this comment.
Build is failing because of these empty files. Either remove them or make them export an empty object and then try the build again
CachedaCodes
suggested changes
Sep 12, 2023
Basic Skeleton added to some files that were empty Co-Authored-By: Matías García Gimeno <[email protected]> Co-Authored-By: Ger-28 <[email protected]>
CachedaCodes
approved these changes
Sep 13, 2023
CachedaCodes
merged commit 9017a64
into
feature/EMP-1944-create-config-module-xcontrols
CachedaCodes
deleted the
feature/EMP-1945/create-skeleton-module-xperience-control
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request template
Describe the purpose of the change, the specific changes done in detail, and the issue you have fixed.
We have added the necessary files to create the skeleton and complete the x-module.
Motivation and context
Type of change
What is the destination branch of this PR?
MainHow has this been tested?
Tests performed according to testing guidelines:
Checklist: