Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load doamin-battery instead of battinfo which is just an extra wrapping #745

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

francescalb
Copy link
Collaborator

Description

This should deprecate PR #741 in which the tests where removed, also incorrectly.

Type of change

  • Bug fix.
  • New feature.
  • Documentation update.
  • Test update.

Checklist

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.18%. Comparing base (052ed1e) to head (ebeefaa).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #745      +/-   ##
==========================================
- Coverage   72.21%   72.18%   -0.03%     
==========================================
  Files          17       17              
  Lines        3462     3462              
==========================================
- Hits         2500     2499       -1     
- Misses        962      963       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jesper-friis jesper-friis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@francescalb francescalb merged commit 09fcba8 into master Apr 10, 2024
11 of 12 checks passed
@francescalb francescalb deleted the update_import_battery_ontology branch April 10, 2024 09:46
@francescalb francescalb mentioned this pull request Apr 10, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants