Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing test #741

Closed
wants to merge 2 commits into from
Closed

Fix failing test #741

wants to merge 2 commits into from

Conversation

jesper-friis
Copy link
Collaborator

Description

Replaced loading battinfo with testonto to avoid failures from battinfo that currently doesn't load properly.

Type of change

  • Bug fix.
  • New feature.
  • Documentation update.
  • Test update.

Checklist

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.15%. Comparing base (052ed1e) to head (ad28076).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #741      +/-   ##
==========================================
- Coverage   72.21%   72.15%   -0.06%     
==========================================
  Files          17       17              
  Lines        3462     3462              
==========================================
- Hits         2500     2498       -2     
- Misses        962      964       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is to circumvent the problem.

The problem is that the catalog is not updated for each import, which means that loading battery.ttl directly works nicely because all the imported ontologies are included in the "parent" catalog-file. This is however, not the case for battinfo, and thus it cannot fine the subontologies.

@francescalb
Copy link
Collaborator

No, this is to circumvent the problem.

The problem is that the catalog is not updated for each import, which means that loading battery.ttl directly works nicely because all the imported ontologies are included in the "parent" catalog-file. This is however, not the case for battinfo, and thus it cannot fine the subontologies.

No, I correct myself. The problem is that the original catalogfile of battinfo is not updated correctly (battery.ttl in master is now at version 0.9). This is dangerous...

francescalb added a commit that referenced this pull request Apr 10, 2024
…ng (#745)

# Description
This should deprecate PR #741 in which the tests where removed, also
incorrectly.

## Type of change
<!-- Put an `x` in the box that applies. -->
- [ ] Bug fix.
- [ ] New feature.
- [ ] Documentation update.
- [ ] Test update.

## Checklist
<!-- Put an `x` in the boxes that apply. You can also fill these out
after creating the PR. -->

This checklist can be used as a help for the reviewer.

- [ ] Is the code easy to read and understand?
- [ ] Are comments for humans to read, not computers to disregard?
- [ ] Does a new feature has an accompanying new test (in the CI or unit
testing schemes)?
- [ ] Has the documentation been updated as necessary?
- [ ] Does this close the issue?
- [ ] Is the change limited to the issue?
- [ ] Are errors handled for all outcomes?
- [ ] Does the new feature provide new restrictions on dependencies, and
if so is this documented?

## Comments
<!-- Additional comments here, including clarifications on checklist if
applicable. -->
@francescalb
Copy link
Collaborator

Clsoed with #745

@francescalb francescalb deleted the replace_battinfo_test branch April 10, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants