Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SUPPORT EMMO-beta4.0 #441

Merged
merged 11 commits into from
Aug 16, 2022
Merged

SUPPORT EMMO-beta4.0 #441

merged 11 commits into from
Aug 16, 2022

Conversation

francescalb
Copy link
Collaborator

@francescalb francescalb commented Aug 12, 2022 •
edited
Loading

emmo-stable +++ on emmo-repo.github.io where changed to emmo-beta4.0
and now a lot of different things fail.

Description:

Type of change:

  • Bug fix.
  • New feature.
  • Documentation update.

Checklist:

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments:

@francescalb
Changed both imported emmo and emmo-inferred to emmo-beta4.0 non infe…
ab1e966 
…rred

Using emmo-beta4.0 from github repo.
Also commented out all tests that fail and need to be fixed one at the
time.

Moved tests/ontopy to tests/ontopy_tests as pytest wanted to import from
this folder and not ontopy for some strange reason
@francescalb
Changed Semiotic to Semiotics in documentation
459cad8
@francescalb francescalb self-assigned this Aug 12, 2022
@francescalb francescalb added the BLOCKING This issue or PR is blocking development ! label Aug 12, 2022
@francescalb francescalb changed the title WIP: SUPPORT EMMO-beta4.0 SUPPORT EMMO-beta4.0 Aug 16, 2022
@CasperWA CasperWA self-requested a review August 16, 2022 13:04
CasperWA
CasperWA approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
My comments are suggested changes, this can be merged without reacting on them in my opinion.

.github/workflows/ci_workflow.yml Show resolved Hide resolved
.github/workflows/ci_workflow.yml Show resolved Hide resolved
@francescalb francescalb merged commit e58dd75 into master Aug 16, 2022
@francescalb francescalb deleted the fix-move-to-beta4 branch August 16, 2022 13:31
This was referenced Aug 16, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CasperWA CasperWA CasperWA approved these changes

Assignees

@francescalb francescalb

Labels
BLOCKING This issue or PR is blocking development !
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@francescalb @CasperWA