Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Fixed bug in graph #410

Closed
wants to merge 3 commits into from
Closed

WIP: Fixed bug in graph #410

wants to merge 3 commits into from

Conversation

jesper-friis
Copy link
Collaborator

Description:

Fixed bug in graph

Type of change:

  • Bug fix.
  • New feature.
  • Documentation update.

Checklist:

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments:

@jesper-friis jesper-friis changed the title Fixed bug in graph WIP: Fixed bug in graph May 8, 2022
@jesper-friis jesper-friis marked this pull request as draft May 8, 2022 21:05
@francescalb
Copy link
Collaborator

@jesper-friis I think this bug (not described what is was), was fixed in #441 in which the style for the edges that are not defines is given as default with the following lines in graph.py:
warnings.warn(
f"Style not defined for relation {name}. "
"Resorting to default style."
)
rattrs = self.style.get("default_relation", {})
Can you verify that this solves your problem? If not, can you describe the bug a little better?

@jesper-friis
Copy link
Collaborator Author

@jesper-friis I think this bug (not described what is was), was fixed in #441 in which the style for the edges that are not defines is given as default with the following lines in graph.py: warnings.warn( f"Style not defined for relation {name}. " "Resorting to default style." ) rattrs = self.style.get("default_relation", {}) Can you verify that this solves your problem? If not, can you describe the bug a little better?

I have completely forgotten what the bug was. Should we simply drop this PR?

@francescalb
Copy link
Collaborator

Then, I close it. Closed with #441

@francescalb francescalb deleted the ontoconvert branch January 17, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants