Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning relation excelparser #366

Merged
merged 10 commits into from
Mar 2, 2022
Merged

Warning relation excelparser #366

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
73474bc
fix #365 add warning and convert nan to None
sygout Feb 8, 2022
988fba8
Apply suggestions from code review
sygout Feb 9, 2022
4e7b331
indentation warning
sygout Feb 9, 2022
f0157ad
merged with remote
sygout Feb 9, 2022
c3effb4
fixing differences
sygout Feb 9, 2022
efec6d0
dealing with pre-commit
sygout Feb 9, 2022
a31c24b
Merge branch 'master' into warning-relation-excelparser
sygout Feb 9, 2022
dd7ca39
Update ontopy/excelparser.py
sygout Feb 9, 2022
29195c7
Merge branch 'master' into warning-relation-excelparser
jesper-friis Feb 22, 2022
a10b670
Merge branch 'master' into warning-relation-excelparser
CasperWA Mar 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions ontopy/excelparser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,9 +282,12 @@ def create_ontology_from_pandas( # pylint:disable=too-many-locals,too-many-bran
)

# Add properties in a second loop

for index in added_rows:
row = data.loc[index]
properties = row["Relations"]
if properties == "nan":
properties = None
if isinstance(properties, str):
try:
concept = onto.get_by_label(row["prefLabel"].strip())
Expand All @@ -301,10 +304,15 @@ def create_ontology_from_pandas( # pylint:disable=too-many-locals,too-many-bran
f"Error is {exc}."
)
except NoSuchLabelError as exc:
msg = (
f"Error in Property assignment for: {concept}. "
f"Property to be Evaluated: {prop}. "
f"Error is {exc}."
)
if force is True:
pass
warnings.warn(msg)
else:
raise ExcelError(exc) from exc
raise ExcelError(msg) from exc

# Synchronise Python attributes to ontology
onto.sync_attributes(
Expand Down