Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning relation excelparser #366

Merged
merged 10 commits into from
Mar 2, 2022
Merged

Warning relation excelparser #366

merged 10 commits into from
Mar 2, 2022

Conversation

sygout
Copy link
Collaborator

@sygout sygout commented Feb 8, 2022

Description:

Type of change:

  • Bug fix.
  • New feature.
  • Documentation update.

Checklist:

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments:

@sygout sygout requested a review from jesper-friis February 8, 2022 09:56
ontopy/excelparser.py Outdated Show resolved Hide resolved
ontopy/excelparser.py Outdated Show resolved Hide resolved
ontopy/excelparser.py Outdated Show resolved Hide resolved
ontopy/excelparser.py Outdated Show resolved Hide resolved
ontopy/excelparser.py Outdated Show resolved Hide resolved
ontopy/excelparser.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@jesper-friis jesper-friis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some suggestions for cleaner code.

ontopy/excelparser.py Outdated Show resolved Hide resolved
Co-authored-by: Jesper Friis <[email protected]>
@CasperWA CasperWA enabled auto-merge March 2, 2022 15:57
@CasperWA CasperWA merged commit 6670b39 into master Mar 2, 2022
@CasperWA CasperWA deleted the warning-relation-excelparser branch March 2, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants