Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ingress handling to a resource processor #3157

Conversation

impl
Copy link
Contributor

@impl impl commented Jan 19, 2021

Description

This change moves the handling of IngressClasses and Ingresses to their own resource processors. Because this was the last Kubernetes type being handled by the fetcher, we also remove the legacy code for handling different types. Going forward, all new Kubernetes object handling will go into a separate processor type.

This change depends on #3156.

Testing

This change passes the automated test suite. No behavior is changing.

Tasks That Must Be Done

  • Did you update CHANGELOG.md?
    • Is this a new feature?
    • Are there any non-backward-compatible changes?
    • Did the envoy version change?
    • Are there any deprecations?
    • Will the changes impact how ambassador performs at scale?
      • Might an existing production deployment need to change:
        • memory limits?
        • cpu limits?
        • replica counts?
      • Does the change impact data-plane latency/scalability?
  • Is your change adequately tested?
    • Was their sufficient test coverage for the area changed?
    • Do the existing tests capture the requirements for the area changed?
    • Is the bulk of your code covered by unit tests?
    • Does at least one end-to-end test cover the integration points your change depends on?
  • Did you update documentation?
  • Were there any special dev tricks you had to use to work on this code efficiently?
    • Did you add them to DEVELOPING.md?
  • Is this a build change?
    • If so, did you test on both Mac and Linux?

@impl impl force-pushed the impl/ingress-resource-processor-additive branch from 00baa14 to 6656723 Compare January 20, 2021 01:06
This change moves the handling of IngressClasses and Ingresses to their
own resource processors. Because this was the last Kubernetes type being
handled by the fetcher, we also remove the legacy code for handling
different types. Going forward, all new Kubernetes object handling will
go into a separate processor type.
@impl impl force-pushed the impl/ingress-resource-processor-additive branch from 6656723 to 09b3709 Compare February 8, 2021 20:47
Copy link
Member

@kflynn kflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that you ran the Ingress tests offline and they passed, I'm'a take this. Thanks!! 🙂

@kflynn kflynn merged commit 19f00d0 into emissary-ingress:master Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants