Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a resource processor for ingresses and ingress classes #3143

Closed

Conversation

impl
Copy link
Contributor

@impl impl commented Jan 9, 2021

Description

This change moves the handlers for the ingress classes and ingresses in the fetcher to their own resource processors. Because of the strange interdependence of the Ambassador service, which must be discovered, ingress classes, and ingresses, we also introduce a dependency handling mechanism that (a) makes it clear where that information is coming from and (b) automatically generates the desired handling order for data coming in from watt.

Related Issues

Testing

New tests were added, and this change was tested against the current integration tests in K3d as well.

Tasks That Must Be Done

  • Did you update CHANGELOG.md?
    • Is this a new feature?
    • Are there any non-backward-compatible changes?
    • Did the envoy version change?
    • Are there any deprecations?
    • Will the changes impact how ambassador performs at scale?
      • Might an existing production deployment need to change:
        • memory limits?
        • cpu limits?
        • replica counts?
      • Does the change impact data-plane latency/scalability?
  • Is your change adequately tested?
    • Was their sufficient test coverage for the area changed?
    • Do the existing tests capture the requirements for the area changed?
    • Is the bulk of your code covered by unit tests?
    • Does at least one end-to-end test cover the integration points your change depends on?
  • Did you update documentation?
  • Were there any special dev tricks you had to use to work on this code efficiently?
    • Did you add them to DEVELOPING.md?
  • Is this a build change?
    • If so, did you test on both Mac and Linux?

@impl impl marked this pull request as ready for review January 12, 2021 08:51
@impl impl force-pushed the impl/ingress-resource-processor branch from 599a676 to d8c9ab7 Compare January 12, 2021 17:12
impl added 3 commits January 12, 2021 09:12
This change moves the handlers for the ingress classes and ingresses in
the fetcher to their own resource processors. Because of the strange
interdependence of the Ambassador service, which must be discovered,
ingress classes, and ingresses, we also introduce a dependency handling
mechanism that (a) makes it clear where that information is coming from
and (b) automatically generates the desired handling order for data
coming in from watt.
@impl
Copy link
Contributor Author

impl commented Jan 19, 2021

Closing in favor of #3155, #3156, and #3157.

@impl impl closed this Jan 19, 2021
@impl impl deleted the impl/ingress-resource-processor branch January 19, 2021 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant