Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate component eventManager #194

Merged
merged 1 commit into from
Mar 26, 2017
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions text/0000-deprecate-custom-event-manager.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
- Start Date: (fill me in with today's date, YYYY-MM-DD)
- RFC PR: (leave this empty)
- Ember Issue: (leave this empty)

# Summary

Support for component `eventManger`s is a seldom used feature and should
be deprecated.

# Motivation

We should strive to simplify the Ember API and source code where possible. As
the custom `eventManager` feature is rarely used in apps, we should deprecate
it.

# Detailed design

We'll introduce a deprecation warning which will be displayed when a component
defines an `eventManager` property or when `canDispatchToEventManager` is set to
true on `EventDispatcher`. The warning will have a target version of `3.0`.

If required, we can create an addon which extends the `EventDispatcher` allowing
for opt-in custom `eventManager`s in Ember apps.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if anyone has a need for this, let me know and I'll create the addon


# How We Teach This

As this is a seldom used feature, we can simply note the deprecation in a
future release blog post.

# Drawbacks

This adds a little more churn for apps that rely on this feature.

# Alternatives

This feature was [recently made pay-as-you-go](https://github.com/emberjs/ember.js/pull/14756),
so the immediate performance concerns have been addressed. We could decide to
leave this in the framework as an opt-in feature.