-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate component eventManager
#194
Deprecate component eventManager
#194
Conversation
eventManager
eventManager
Awesome, thank you for putting this together! We should also have this deprecation cover the |
I haven't used this feature before, but if I did, what would be the alternative to using it? (how do I un-deprecate my code) |
@kellyselden you could extend |
true on `EventDispatcher`. The warning will have a target version of `3.0`. | ||
|
||
If required, we can create an addon which extends the `EventDispatcher` allowing | ||
for opt-in custom `eventManager`s in Ember apps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if anyone has a need for this, let me know and I'll create the addon
@GavinJoyce Addon route seems like a good idea to me. |
Sorry for the delay here. We discussed in the core team meeting on 2017-01-20, and are 👍 on moving this to final comment period. |
I'm merging this, as we are certainly past the one-week window and I see no new comments 😗 Thank you! |
Rendered
Part of emberjs/ember.js#14754