Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace small Tomster icons with Ember's 'e' icon #876

Merged
merged 4 commits into from
Nov 7, 2018

Conversation

dipil-saud
Copy link
Contributor

Resolves #871

These are the different areas where the 'e' icon is added:

  • 'Inspect Ember Component' context menu
  • 'Webpage is running Ember' Indicator icons

Also adds a higher quality icon for the firefox devloper tab.

@RobbieTheWagner
Copy link
Member

Thanks so much for the PR! This looks awesome 😄

I see we are still using Tomster in some spots. @locks @teddyzeenny what do you guys think about removing Tomster entirely and just going with the "e" logo everywhere? Might feel a little more uniform, but I am open to whatever.

@locks
Copy link
Contributor

locks commented Oct 12, 2018

@rwwagner90 I think that is likely a good idea. While I love Tomster, it is too busy visually at small sizes.

@RobbieTheWagner
Copy link
Member

Thanks for the feedback @locks 👍

@dipil-saud with this in mind, can you please remove the remaining Tomster icons and replace with the same "e" logo?

Copy link
Member

@RobbieTheWagner RobbieTheWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dipil-saud can you please replace all tomster icons with the e icon? Then this should be good to merge 👍

@RobbieTheWagner
Copy link
Member

@dipil-saud we could also potentially replace the others after the fact, if you do not have bandwidth to make the change. Just let me know!

@dipil-saud
Copy link
Contributor Author

@rwwagner90 I'll make the changes. Was AFW for a while.

@dipil-saud dipil-saud force-pushed the update-component-icon branch from 456de46 to 308c044 Compare October 17, 2018 16:14
@RobbieTheWagner RobbieTheWagner merged commit 9793423 into emberjs:master Nov 7, 2018
cyril-sf pushed a commit to cyril-sf/ember-inspector that referenced this pull request Mar 30, 2022
* Update the component icon from the tomster to ember's rounded-square ‘e’ icon.

* Updates text from 'tomster' to 'ember icon' where the image was changed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants