-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace small Tomster icons with Ember's 'e' icon #876
Replace small Tomster icons with Ember's 'e' icon #876
Conversation
Thanks so much for the PR! This looks awesome 😄 I see we are still using Tomster in some spots. @locks @teddyzeenny what do you guys think about removing Tomster entirely and just going with the "e" logo everywhere? Might feel a little more uniform, but I am open to whatever. |
@rwwagner90 I think that is likely a good idea. While I love Tomster, it is too busy visually at small sizes. |
Thanks for the feedback @locks 👍 @dipil-saud with this in mind, can you please remove the remaining Tomster icons and replace with the same "e" logo? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dipil-saud can you please replace all tomster icons with the e icon? Then this should be good to merge 👍
@dipil-saud we could also potentially replace the others after the fact, if you do not have bandwidth to make the change. Just let me know! |
@rwwagner90 I'll make the changes. Was AFW for a while. |
456de46
to
308c044
Compare
* Update the component icon from the tomster to ember's rounded-square ‘e’ icon. * Updates text from 'tomster' to 'ember icon' where the image was changed.
Resolves #871
These are the different areas where the 'e' icon is added:
Also adds a higher quality icon for the firefox devloper tab.