Replace small Tomster icons with Ember's 'e' icon (emberjs#876)

* Update the component icon from the tomster to ember's rounded-square ‘e’ icon. * Updates text from 'tomster' to 'ember icon' where the image was changed.
cyril-sf · Mar 30, 2022 · 4def28e · 4def28e
1 parent ccc8efc
commit 4def28e
Show file tree

Hide file tree

Showing 18 changed files with 17 additions and 15 deletions.
diff --git a/public/assets/images/ember-icon-final.png b/public/assets/images/ember-icon-final.png
diff --git a/public/assets/images/hamster.png b/public/assets/images/hamster.png
diff --git a/public/assets/images/icon128.png b/public/assets/images/icon128.png
diff --git a/public/assets/images/icon16.png b/public/assets/images/icon16.png
diff --git a/public/assets/images/icon19.png b/public/assets/images/icon19.png
diff --git a/public/assets/images/icon38.png b/public/assets/images/icon38.png
diff --git a/public/assets/images/icon48.png b/public/assets/images/icon48.png
diff --git a/public/assets/images/tomster.png b/public/assets/images/tomster.png
diff --git a/public/assets/svg/ember-icon.svg b/public/assets/svg/ember-icon.svg
diff --git a/skeletons/firefox/data/toolbar-button-panel.html b/skeletons/firefox/data/toolbar-button-panel.html
@@ -15,7 +15,7 @@
     </style>
   </head>
   <body>
-    <img src="./images/icon48.png">
+    <img src="./svg/ember-icon.svg">
     <h5>
       Ember Inspector <u id="inspectorVersion">VERSION</u>
     </h5>

diff --git a/skeletons/firefox/lib/tomster-devtool-panel.js b/skeletons/firefox/lib/tomster-devtool-panel.js
@@ -30,7 +30,7 @@ exports.openEmberInspector = function () {
 exports.devtoolTabDefinition = {
   id: "ember-inspector",
   ordinal: 7,
-  icon: self.data.url("{{PANE_ROOT}}/assets/images/icon19.png"),
+  icon: self.data.url("{{PANE_ROOT}}/assets/svg/ember-icon.svg"),
   url: self.data.url("devtool-panel.html"),
   label: "Ember{{env}}",
   tooltip: "Ember Inspector",
@@ -102,7 +102,7 @@ let EmberInspector = Class({
 
   /**
    * Keep track of the last version.
-   * 
+   *
    * @propery _lastVersion
    * @type {String}
    */

diff --git a/skeletons/firefox/package.json b/skeletons/firefox/package.json
@@ -8,8 +8,8 @@
   "main": "lib/main.js",
   "preferences": [{
     "name": "tomsterLocationbarButtonToggle",
-        "title": "Display The Tomster icon when a site runs Ember.js",
-        "description": "Display The Tomster icon when a site runs Ember.js",
+        "title": "Display The Ember icon when a site runs Ember.js",
+        "description": "Display The Ember icon when a site runs Ember.js",
         "type": "bool",
         "value": false
   }]

diff --git a/skeletons/web-extension/background-script.js b/skeletons/web-extension/background-script.js
@@ -6,7 +6,7 @@
  * ClientApp.  The background-script serves as a proxy between the EmberInspector
  * and the content-script.
  *
- * It is also responsible for showing the Tomster icon and tooltip in the url bar.
+ * It is also responsible for showing the Ember icon and tooltip in the url bar.
  *
  * See:
  *     https://developer.chrome.com/extensions/background_pages
@@ -57,7 +57,7 @@
   }
 
   /**
-   * Remove the curent tab's Tomster.
+   * Remove the curent tab's Ember icon.
    * Typically used to clearout the icon after reload.
    * @param {Number} tabId - the current tab
    */
@@ -152,7 +152,7 @@
       updateTabAction(sender.tab.id);
       updateContextMenu();
     } else if (request && request.type === 'resetEmberIcon') {
-      // hide the Tomster icon
+      // hide the Ember icon
       hideAction(sender.tab.id);
     } else if (request && request.type === 'inspectorLoaded') {
       updateContextMenu(true);

diff --git a/skeletons/web-extension/devtools.js b/skeletons/web-extension/devtools.js
@@ -6,4 +6,4 @@
  */
 var panelWindow, injectedPanel = false, injectedPage = false, panelVisible = false, savedStack = [];
 
-chrome.devtools.panels.create("Ember{{env}}", "{{PANE_ROOT}}/assets/images/icon16.png", "{{PANE_ROOT}}/index.html");
+chrome.devtools.panels.create("Ember{{env}}", "{{PANE_ROOT}}/assets/svg/ember-icon.svg", "{{PANE_ROOT}}/index.html");
diff --git a/skeletons/web-extension/manifest.json b/skeletons/web-extension/manifest.json
@@ -7,6 +7,7 @@
 
   "icons": {
     "16":  "{{PANE_ROOT}}/assets/images/icon16.png",
+    "32": "{{PANE_ROOT}}/assets/images/icon38.png",
     "48":  "{{PANE_ROOT}}/assets/images/icon48.png",
     "128": "{{PANE_ROOT}}/assets/images/icon128.png"
   },

diff --git a/skeletons/web-extension/options-dialog.html b/skeletons/web-extension/options-dialog.html
@@ -12,8 +12,8 @@
 <body>
   <label>
     <input type="checkbox" data-settings="tomster">
-    Display the Tomster
-    <img src="/{{PANE_ROOT}}/assets/images/icon19.png" width="19" height="19">
+    Display the Ember favicon
+    <img src="/{{PANE_ROOT}}/assets/svg/ember-icon.svg" width="19" height="19">
     when a site runs Ember.js
   </label>
   <script src="options.js"></script>

diff --git a/skeletons/web-extension/options.html b/skeletons/web-extension/options.html
@@ -22,7 +22,7 @@
 
   <div class="frame">
     <div class="navigation">
-      <img src="/{{PANE_ROOT}}/assets/images/tomster.png" width="100" height="95">
+      <img src="/{{PANE_ROOT}}/assets/svg/ember-icon.svg" width="100" height="95">
       <ul class="menu">
         <li class="selected">
           <a href="#">Settings</a>
@@ -47,8 +47,8 @@ <h1>Settings</h1>
           <form action="submit">
             <label class="tomster-toggle">
               <input type="checkbox" data-settings="tomster">
-              Display the Tomster
-              <img src="/{{PANE_ROOT}}/assets/images/icon19.png" width="19" height="19">
+              Display the Ember favicon
+              <img src="/{{PANE_ROOT}}/assets/svg/ember-icon.svg" width="19" height="19">
               when a site runs Ember.js
             </label>
           </form>

diff --git a/skeletons/web-extension/options.js b/skeletons/web-extension/options.js
@@ -2,7 +2,7 @@
 
 /**
  * Extension options for Chrome.
- * This allows the user to decide if the Tomster icon should show when visiting
+ * This allows the user to decide if the Ember icon should show when visiting
  * a webpage that has Ember running.
  *
  * see: