Route Search #798
Closed
Route Search #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Inspect Views Icon
UI Tweaks to Match Latest Inspectors
Drop ember-new-computed (closes emberjs#745)
Fix loading main outlet
Start converting to module imports
Allow for empty mixins
ember-qunit-codemod
Add Documentation + Minor Cleanup
Fix file paths displayed in the Routes tab
According to @krisselden this is not needed, and `meta.moduleName` is already what we want. With that in mind, I am removing this stuff. Fixes emberjs#750
According to @rwjblue and @teddyzeenny we should no longer need this. Fixes emberjs#758
Remove getTemplate stuff
Remove computedPolyfill
* Bump some deps * Remove manual sass and lint * First pass at ember 3 * Fix the first container test * Convert to ember-test-helpers * Use vertical-collection * Use positional param for VC * Fix some lint issues * Fix the view tree * Add trs with classes * Add imports for wait helper * Fix class * WIP * Remove usage of container-instance for simple action case. * Fix acceptance test to use `find` / `findAll` without "context" element. * Tweak ember debug tests to use newer ember testing setup.. * Fix a bunch of tests * Remove unused container-instance component * Fix more tests, use location: none * Fix rootElement and binding tests * Fix some missed __container__ * Lint ember_debug * Fix getClassName resolver * Add ember-try * Filter ember-try to only test ember_debug * Attempt to use stages * Try to fix stages * Try another env * Try matrix * Adjust matrix more * Add missing : * Fix indent lint * fail_fast: false so we can see all test results * Travis tweaks * Move script to stage * Maybe fix stage? * Remove stages config, set script back to global * Since stages do not proceed if the previous fails, switch them * Bump ember-try, fix owner.factoryFor * Restrict to master for builds * Try skip cleanup * Try to fix some hover issues * Test with more ember versions * Use short name for view * Use Ember.Component instead of Ember.View * Use controller.controller We had an issue with controller._controller. * Super hacky workaround for 2.10 * Work around computed issues in 3.1+ tests * Fix lint issues * Fix calculating computeds, cleanup TODOs * Remove RowEventsMixin, move actions to trs * Update yarn commands * Fix view preview layer test * Revert preview layer changes * Revert previews, fix tests * Remove the index property It was used with EventRow mixin * Remove ember-math-helpers * Confirm removal of eslint test generator
Bump version to 3.0.0
Avoid error in some environments
Fix inspector reset on client app's reset and destroy
Fix text field assertion
Add branches to build in Travis CI
* Remove jQuery from app Also had to switch to a new context menu plugin. This should get us closer to emberjs#590 * Add missing comma
This uses https://github.com/skywinder/github-changelog-generator to generate changelogs for us. We just need to start labeling issues.
* Pill CSS cleanup Match BEM syntax in other parts of the app * Lighten grays on background and borders I chose grays that in the middle of the lighter UI in Firefox and the darker UI in Chrome * High resolution Fishy Tomster image * Mixin sidebar cleanup - More consistent BEM CSS syntax - Whitespace here and there - Text and icon alignment * New Navigation icons Thanks project Clarity: https://vmware.github.io/clarity These icons are consistent in weight and style * Button for clearing search inputs * Toolbar tweaks - Increase height - Consistent space around items - More clickable space around items - more visible selected item for toolbar radios * Search consistification - Common partial for search fields - Same property name for text * Bring in svg-jar add-on * Search-field component
* Fix setIsDragging test errors * Fix lint * Pass setIsDragging where missed, use layoutService instead of layout
* WIP First crack at component tree view This first pass at a component tree is basically a stripped down copy of the view tree. Features: - Clicking a component name opens the object inspector for that component. - Hovering on a component will toggle the preview layer in the application DOM. - Collapsible components A ton of stuff is totally arbitrary right now but it's a starting point. Filtering out non-component views isn't implemented yet. No tests yet either as this is a rough spike. * New down arrow SVG * WIP First crack at styling component tree view * WIP basic search Filters items based on search result TODO: - Reset indentation level to 0 for results but still allow for expansion ala react devtools * Rename 'Component Tree' -> 'Components' * Remove component selector from toolbar * Select items in the DOM w/common selector button This works just like the view tree, but slightly enhanced. When a component is 'pinned' it also shows up as selected in the tree. KNOWN PROBLEMS: - if the component is not technically visible it won't show up - It'd probably be nice if the pinned component was scrolled into view in our tree view as well. * Set view-debug options for individual routes * Scroll to view icon for Component Tree * Update padding to better clarify which elements are siblings in the tree * Add basic scroll to element support * Small code cleanup * Don't try to scroll if element is not found * Cache expanded state of tree nodes When the view tree refreshes it's jarring if a node the user had collapsed suddenly expands. We cache the expanded states and reconcile the state of the new nodes against the cache to avoid it. * Cache expanded state of tree nodes When the view tree refreshes it's jarring if a node the user had collapsed suddenly expands. We cache the expanded states and reconcile the state of the new nodes against the cache to avoid it. * Update component icon * Fix iframe dropdown styles * Consistent property name for search * Add more tests * eye svg to svg-jar * Wrap svg-jar in div for click handling For whatever reason trying to attach the event handler directly causes an error, so we'll wrap it. * Component tree clear search test * Component tree item spacing and alignment fixes * More component tree alignment tweaks * Clean up tree flattening code and add comments * Different styles and behavior for views in Component Tree * Component tree expand and collapse all Icons and placeholder actions * Make all of component tree item clickable * ExpandAll uses filteredArray rather than viewTree The downstream properties only check that the viewTree's membership has changed, not the individual properties. * Expand parents for inspected components * Update tree tests after styling change * Respond to PR feedback - Remove unused model hook - Extract ComponentViewItem to a separate file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[NOTE] — ran into an older branch with the same name, closing and opening a new PR.
#129