Avoid error in some environments #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teddyzeenny
reviewed
Mar 3, 2017
There was a problem hiding this comment.
Thanks, looks good! Should we also set/remove a value like we did for local storage detection?
|
Thought of that, but opted for not doing it simply to avoid adding code whose purpose I don't really know. If you think it's worth doing, I can add that. |
pablobm
force-pushed
the
session-storage-check
branch
from
20d409e to
3fd6809
Compare
|
I rebased this today, and the build failed. Looks like three environments timed out before even trying to run the tests. Would it be possible to rerun the build, please? |
|
Done! |
| if (typeof sessionStorage !== 'undefined') { | ||
| SESSION_STORAGE_SUPPORTED = true; | ||
| } | ||
| } catch (e) { |
There was a problem hiding this comment.
Do we want to log any sort of message here or does just catching the error retain the functionality, so everything appears good?
There was a problem hiding this comment.
Catching the error retains the functionality, so everything appears good.
RobbieTheWagner
approved these changes
Mar 5, 2018
rwjblue
approved these changes
Mar 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be a problem, in very specific circumstances, with the code that detects support for session storage:
To reproduce follow these steps:
loaded from a different domain
It's important that the Ember inspector is already open when you land on the page (hence step 4 before 5). Reloading the iframe page with the Ember inspector open also reproduces the problem.
This PR appears to fix the problem for me.